From 781d539e7f3e9727382d0da299ec8bf628755e5a Mon Sep 17 00:00:00 2001 From: Pedro Silva Date: Fri, 28 Jul 2023 16:37:44 +0100 Subject: [PATCH] Refactor hosted fields for early card detection --- .../js/modules/Renderer/CreditCardRenderer.js | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js b/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js index fcd20a609..9cd6e345c 100644 --- a/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js +++ b/modules/ppcp-button/resources/js/modules/Renderer/CreditCardRenderer.js @@ -122,24 +122,17 @@ class CreditCardRenderer { const className = this._cardNumberFiledCLassNameByCardType(event.cards[0].type); this._recreateElementClassAttribute(cardNumber, cardNumberField.className); - if (event.fields.number.isValid) { + if (event.cards.length === 1) { cardNumber.classList.add(className); } }) hostedFields.on('validityChange', (event) => { - const formValid = Object.keys(event.fields).every(function (key) { + this.formValid = Object.keys(event.fields).every(function (key) { return event.fields[key].isValid; }); - - const className = event.cards.length ? this._cardNumberFiledCLassNameByCardType(event.cards[0].type) : ''; - event.fields.number.isValid - ? cardNumber.classList.add(className) - : this._recreateElementClassAttribute(cardNumber, cardNumberField.className); - - this.formValid = formValid; - }); hostedFields.on('empty', (event) => { + this._recreateElementClassAttribute(cardNumber, cardNumberField.className); this.emptyFields.add(event.emittedBy); }); hostedFields.on('notEmpty', (event) => {