woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-01 07:02:48 +08:00
Code Issues Projects Packages Wiki Activity Actions

Fix price sorting error by filtering null values before sort

Browse source 
Prevents "TypeError: a is null" when comparing prices.
This commit is contained in:
carmenmaymo 2025-05-19 16:13:32 +02:00
parent f038cbc2b0
commit 0eb2f1258a
No known key found for this signature in database
GPG key ID: 6023F686B0F3102E
1 changed files with 10 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

16
modules/ppcp-button/resources/js/modules/ContextBootstrap/SingleProductBootstrap.js
View file

@ -162,12 +162,16 @@ class SingleProductBootstrap {
},
]
.map( ( f ) => f() )
.sort((a, b) => {
if (parseInt(a.replace(/\D/g, '')) < parseInt(b.replace(/\D/g, '')) ) {
return 1;
}
return -1;
})
.filter( ( val ) => val !== null && val !== undefined )
.sort( ( a, b ) => {
if (
parseInt( a.replace( /\D/g, '' ) ) <
parseInt( b.replace( /\D/g, '' ) )
) {
return 1;
}
return -1;
} )
.find( ( val ) => val );
if ( typeof priceText === 'undefined' ) {