woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-06 18:16:38 +08:00
Code Issues Projects Packages Wiki Activity Actions

Merge pull request #2026 from woocommerce/PCP-2651-store-card-brand-in-address-verification-result-instead-of-3-ds-authentication-result

Browse source 
Store the Card Brand in Address Verification Result instead of 3DS authentication result (2651)
This commit is contained in:
Emili Castells 2024-02-16 12:04:07 +01:00 • committed by GitHub
commit 0daa053873
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/ppcp-button/src/Helper/ThreeDSecure.php
View file

@ -78,7 +78,7 @@ class ThreeDSecure {
if ( $authentication_result ) { if ( $authentication_result ) {
$result = $this->card_authentication_result_factory->from_paypal_response( $authentication_result ); $result = $this->card_authentication_result_factory->from_paypal_response( $authentication_result );
$this->logger->info( '3DS authentication result: ' . wc_print_r( $result->to_array(), true ) ); $this->logger->info( '3DS Authentication Result: ' . wc_print_r( $result->to_array(), true ) );
if ( $result->liability_shift() === AuthResult::LIABILITY_SHIFT_POSSIBLE ) { if ( $result->liability_shift() === AuthResult::LIABILITY_SHIFT_POSSIBLE ) {
return self::PROCCEED; return self::PROCCEED;

23
modules/ppcp-wc-gateway/src/Processor/CreditCardOrderInfoHandlingTrait.php
View file

@ -40,20 +40,18 @@ trait CreditCardOrderInfoHandlingTrait {
} }
$authentication_result = $payment_source->properties()->authentication_result ?? null; $authentication_result = $payment_source->properties()->authentication_result ?? null;
$card_brand = $payment_source->properties()->brand ?? __( 'N/A', 'woocommerce-paypal-payments' );
if ( $authentication_result ) { if ( $authentication_result ) {
$card_authentication_result_factory = new CardAuthenticationResultFactory(); $card_authentication_result_factory = new CardAuthenticationResultFactory();
$result = $card_authentication_result_factory->from_paypal_response( $authentication_result ); $result = $card_authentication_result_factory->from_paypal_response( $authentication_result );
$three_d_response_order_note_title = __( '3DS authentication result', 'woocommerce-paypal-payments' ); $three_d_response_order_note_title = __( '3DS Authentication Result', 'woocommerce-paypal-payments' );
/* translators: %1$s is 3DS order note title, %2$s is 3DS order note result markup */ /* translators: %1$s is 3DS order note title, %2$s is 3DS order note result markup */
$three_d_response_order_note_format = __( '%1$s %2$s', 'woocommerce-paypal-payments' ); $three_d_response_order_note_format = __( '%1$s %2$s', 'woocommerce-paypal-payments' );
$three_d_response_order_note_result_format = '<ul class="ppcp_3ds_result"> $three_d_response_order_note_result_format = '<ul class="ppcp_3ds_result">
<li>%1$s</li> <li>%1$s</li>
<li>%2$s</li> <li>%2$s</li>
<li>%3$s</li> <li>%3$s</li>
<li>%4$s</li>
</ul>'; </ul>';
$three_d_response_order_note_result = sprintf( $three_d_response_order_note_result = sprintf(
$three_d_response_order_note_result_format, $three_d_response_order_note_result_format,
@ -62,9 +60,7 @@ trait CreditCardOrderInfoHandlingTrait {
/* translators: %s is enrollment status */ /* translators: %s is enrollment status */
sprintf( __( 'Enrollment Status: %s', 'woocommerce-paypal-payments' ), esc_html( $result->enrollment_status() ) ), sprintf( __( 'Enrollment Status: %s', 'woocommerce-paypal-payments' ), esc_html( $result->enrollment_status() ) ),
/* translators: %s is authentication status */ /* translators: %s is authentication status */
sprintf( __( 'Authentication Status: %s', 'woocommerce-paypal-payments' ), esc_html( $result->authentication_result() ) ), sprintf( __( 'Authentication Status: %s', 'woocommerce-paypal-payments' ), esc_html( $result->authentication_result() ) )
/* translators: %s is card brand */
sprintf( __( 'Card Brand: %s', 'woocommerce-paypal-payments' ), esc_html( $card_brand ) )
); );
$three_d_response_order_note = sprintf( $three_d_response_order_note = sprintf(
$three_d_response_order_note_format, $three_d_response_order_note_format,
@ -74,8 +70,7 @@ trait CreditCardOrderInfoHandlingTrait {
$wc_order->add_order_note( $three_d_response_order_note ); $wc_order->add_order_note( $three_d_response_order_note );
$meta_details = array_merge( $result->to_array(), array( 'card_brand' => $card_brand ) ); $wc_order->update_meta_data( PayPalGateway::THREE_D_AUTH_RESULT_META_KEY, $result->to_array() );
$wc_order->update_meta_data( PayPalGateway::THREE_D_AUTH_RESULT_META_KEY, $meta_details );
$wc_order->save_meta_data(); $wc_order->save_meta_data();
/** /**
@ -101,7 +96,9 @@ trait CreditCardOrderInfoHandlingTrait {
return; return;
} }
$fraud_responses = $fraud->to_array(); $fraud_responses = $fraud->to_array();
$card_brand = $payment_source->properties()->brand ?? __( 'N/A', 'woocommerce-paypal-payments' );
$avs_response_order_note_title = __( 'Address Verification Result', 'woocommerce-paypal-payments' ); $avs_response_order_note_title = __( 'Address Verification Result', 'woocommerce-paypal-payments' );
/* translators: %1$s is AVS order note title, %2$s is AVS order note result markup */ /* translators: %1$s is AVS order note title, %2$s is AVS order note result markup */
$avs_response_order_note_format = __( '%1$s %2$s', 'woocommerce-paypal-payments' ); $avs_response_order_note_format = __( '%1$s %2$s', 'woocommerce-paypal-payments' );
@ -111,6 +108,7 @@ trait CreditCardOrderInfoHandlingTrait {
<li>%2$s</li> <li>%2$s</li>
<li>%3$s</li> <li>%3$s</li>
</ul> </ul>
<li>%4$s</li>
</ul>'; </ul>';
$avs_response_order_note_result = sprintf( $avs_response_order_note_result = sprintf(
$avs_response_order_note_result_format, $avs_response_order_note_result_format,
@ -119,7 +117,9 @@ trait CreditCardOrderInfoHandlingTrait {
/* translators: %s is fraud AVS address match */ /* translators: %s is fraud AVS address match */
sprintf( __( 'Address Match: %s', 'woocommerce-paypal-payments' ), esc_html( $fraud_responses['address_match'] ) ), sprintf( __( 'Address Match: %s', 'woocommerce-paypal-payments' ), esc_html( $fraud_responses['address_match'] ) ),
/* translators: %s is fraud AVS postal match */ /* translators: %s is fraud AVS postal match */
sprintf( __( 'Postal Match: %s', 'woocommerce-paypal-payments' ), esc_html( $fraud_responses['postal_match'] ) ) sprintf( __( 'Postal Match: %s', 'woocommerce-paypal-payments' ), esc_html( $fraud_responses['postal_match'] ) ),
/* translators: %s is card brand */
sprintf( __( 'Card Brand: %s', 'woocommerce-paypal-payments' ), esc_html( $card_brand ) )
); );
$avs_response_order_note = sprintf( $avs_response_order_note = sprintf(
$avs_response_order_note_format, $avs_response_order_note_format,
@ -136,7 +136,8 @@ trait CreditCardOrderInfoHandlingTrait {
); );
$wc_order->add_order_note( $cvv_response_order_note ); $wc_order->add_order_note( $cvv_response_order_note );
$wc_order->update_meta_data( PayPalGateway::FRAUD_RESULT_META_KEY, $fraud_responses ); $meta_details = array_merge( $fraud_responses, array( 'card_brand' => $card_brand ) );
$wc_order->update_meta_data( PayPalGateway::FRAUD_RESULT_META_KEY, $meta_details );
$wc_order->save_meta_data(); $wc_order->save_meta_data();
/** /**