woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-09-04 08:47:23 +08:00
Code Issues Projects Packages Wiki Activity Actions 11

Return status instead of bool + last_status

Browse source
This commit is contained in:
Alex P 2021-10-04 18:36:30 +03:00
parent c6229c9944
commit 07928c9935
5 changed files with 21 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

15
tests/PHPUnit/WcGateway/Gateway/WcGatewayTest.php
View file

@ -227,10 +227,7 @@ class WcGatewayTest extends TestCase
$authorizedPaymentsProcessor
->expects('process')
->with($wcOrder)
->andReturnTrue();
$authorizedPaymentsProcessor
->expects('last_status')
->andReturn(AuthorizedPaymentsProcessor::SUCCESSFUL);
->andReturn(AuthorizedPaymentsProcessor::SUCCESSFUL);
$authorizedOrderActionNotice = Mockery::mock(AuthorizeOrderActionNotice::class);
$authorizedOrderActionNotice
->expects('display_message')
@ -286,10 +283,7 @@ class WcGatewayTest extends TestCase
$authorizedPaymentsProcessor
->expects('process')
->with($wcOrder)
->andReturnFalse();
$authorizedPaymentsProcessor
->shouldReceive('last_status')
->andReturn(AuthorizedPaymentsProcessor::ALREADY_CAPTURED);
->andReturn(AuthorizedPaymentsProcessor::ALREADY_CAPTURED);
$authorizedOrderActionNotice = Mockery::mock(AuthorizeOrderActionNotice::class);
$authorizedOrderActionNotice
->expects('display_message')
@ -338,10 +332,7 @@ class WcGatewayTest extends TestCase
$authorizedPaymentsProcessor
->expects('process')
->with($wcOrder)
->andReturnFalse();
$authorizedPaymentsProcessor
->shouldReceive('last_status')
->andReturn($lastStatus);
->andReturn($lastStatus);
$authorizedOrderActionNotice = Mockery::mock(AuthorizeOrderActionNotice::class);
$authorizedOrderActionNotice
->expects('display_message')

18
tests/PHPUnit/WcGateway/Processor/AuthorizedPaymentsProcessorTest.php
View file

@ -55,8 +55,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
->with($this->authorizationId)
->andReturn($this->createAuthorization($this->authorizationId, AuthorizationStatus::CAPTURED));
$this->assertTrue($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::SUCCESSFUL, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::SUCCESSFUL, $testee->process($this->wcOrder));
}
public function testCapturesAllCaptureable() {
@ -80,8 +79,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
->andReturn($this->createAuthorization($authorization->id(), AuthorizationStatus::CAPTURED));
}
$this->assertTrue($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::SUCCESSFUL, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::SUCCESSFUL, $testee->process($this->wcOrder));
}
public function testInaccessible() {
@ -93,8 +91,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
$testee = new AuthorizedPaymentsProcessor($orderEndpoint, $this->paymentsEndpoint);
$this->assertFalse($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::INACCESSIBLE, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::INACCESSIBLE, $testee->process($this->wcOrder));
}
public function testNotFound() {
@ -106,8 +103,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
$testee = new AuthorizedPaymentsProcessor($orderEndpoint, $this->paymentsEndpoint);
$this->assertFalse($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::NOT_FOUND, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::NOT_FOUND, $testee->process($this->wcOrder));
}
public function testCaptureFails() {
@ -118,8 +114,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
->with($this->authorizationId)
->andThrow(RuntimeException::class);
$this->assertFalse($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::FAILED, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::FAILED, $testee->process($this->wcOrder));
}
public function testAlreadyCaptured() {
@ -127,8 +122,7 @@ class AuthorizedPaymentsProcessorTest extends TestCase
$this->paypalOrder = $this->createPaypalOrder([$this->createAuthorization($this->authorizationId, AuthorizationStatus::CAPTURED)]);
$this->assertFalse($testee->process($this->wcOrder));
$this->assertEquals(AuthorizedPaymentsProcessor::ALREADY_CAPTURED, $testee->last_status());
$this->assertEquals(AuthorizedPaymentsProcessor::ALREADY_CAPTURED, $testee->process($this->wcOrder));
}
private function createWcOrder(string $paypalOrderId): WC_Order {