woocommerce/woocommerce-paypal-payments
2
0
Fork 0
mirror of https://github.com/woocommerce/woocommerce-paypal-payments.git synced 2025-08-31 06:52:50 +08:00
Code Issues Projects Packages Wiki Activity Actions

♻️ Refactor the settingsdata manager constructor

Browse source
This commit is contained in:
Philipp Stracker 2025-02-12 21:06:47 +01:00
parent 34c67bb8d1
commit 0728f80281
No known key found for this signature in database
2 changed files with 19 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
modules/ppcp-settings/services.php
View file

@ -249,17 +249,14 @@ return array(
return new DataSanitizer();
},
'settings.service.data-manager' => static function ( ContainerInterface $container ) : SettingsDataManager {
$models = array(
return new SettingsDataManager(
$container->get( 'settings.data.onboarding' ),
$container->get( 'settings.data.general' ),
$container->get( 'settings.data.settings' ),
$container->get( 'settings.data.styling' ),
$container->get( 'settings.data.payment' ),
$container->get( 'settings.data.settings' ),
$container->get( 'settings.data.todos' ),
$container->get( 'settings.data.definition.todos' ),
);
return new SettingsDataManager( $models );
},
'settings.ajax.switch_ui' => static function ( ContainerInterface $container ) : SwitchSettingsUiEndpoint {
return new SwitchSettingsUiEndpoint(

22
modules/ppcp-settings/src/Service/SettingsDataManager.php
View file

@ -10,6 +10,7 @@ declare( strict_types = 1 );
namespace WooCommerce\PayPalCommerce\Settings\Service;
use WooCommerce\PayPalCommerce\Settings\Data\AbstractDataModel;
use WooCommerce\PayPalCommerce\Settings\Data\OnboardingProfile;
/**
* Class SettingsDataManager
@ -19,25 +20,36 @@ use WooCommerce\PayPalCommerce\Settings\Data\AbstractDataModel;
*/
class SettingsDataManager {
/**
* The onboarding profile data model.
*
* @var OnboardingProfile
*/
private OnboardingProfile $onboarding_profile;
/**
* Stores a list of all AbstractDataModel instances that are managed by
* this service.
*
* @var AbstractDataModel[]
*/
private array $models = array();
private array $purgeable_models = array();
/**
* Constructor.
*
* @param array $data_models List of AbstractDataModel instances.
* @param OnboardingProfile $onboarding_profile The onboarding profile model.
* @param array ...$data_models List of additional data models to reset.
*/
public function __construct( array $data_models ) {
public function __construct( OnboardingProfile $onboarding_profile, ...$data_models ) {
foreach ( $data_models as $data_model ) {
if ( $data_model instanceof AbstractDataModel ) {
$this->models[] = $data_model;
$this->purgeable_models[] = $data_model;
}
}
$this->purgeable_models[] = $onboarding_profile;
$this->onboarding_profile = $onboarding_profile;
}
/**
@ -52,7 +64,7 @@ class SettingsDataManager {
*/
do_action( 'woocommerce_paypal_payments_reset_settings' );
foreach ( $this->models as $model ) {
foreach ( $this->purgeable_models as $model ) {
$model->purge();
}