From 0502c25ddf684a1d56465838da355c376a0cc6a6 Mon Sep 17 00:00:00 2001
From: Philipp Stracker
Date: Fri, 6 Dec 2024 15:50:58 +0100
Subject: [PATCH] =?UTF-8?q?=E2=99=BB=EF=B8=8F=20Rename=20callback=20method?=
=?UTF-8?q?s,=20minor?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
---
.../resources/js/hooks/useHandleConnections.js | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js b/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
index d242b1de9..10d164cea 100644
--- a/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
+++ b/modules/ppcp-settings/resources/js/hooks/useHandleConnections.js
@@ -65,11 +65,11 @@ const useConnectionBase = () => {
useDispatch( noticesStore );
return {
- handleError: ( res, genericMessage ) => {
+ handleFailed: ( res, genericMessage ) => {
console.error( 'Connection error', res );
createErrorNotice( res?.message ?? genericMessage );
},
- handleSuccess: async () => {
+ handleCompleted: async () => {
createSuccessNotice( MESSAGES.CONNECTED );
// TODO: Contact the plugin to confirm onboarding is completed.
@@ -80,14 +80,14 @@ const useConnectionBase = () => {
};
const useConnectionAttempt = ( connectFn, errorMessage ) => {
- const { handleError, createErrorNotice, handleSuccess } =
+ const { handleFailed, createErrorNotice, handleCompleted } =
useConnectionBase();
return async ( ...args ) => {
const res = await connectFn( ...args );
if ( ! res.success || ! res.data ) {
- handleError( res, errorMessage );
+ handleFailed( res, errorMessage );
return false;
}
@@ -97,7 +97,7 @@ const useConnectionAttempt = ( connectFn, errorMessage ) => {
);
if ( popupClosed ) {
- await handleSuccess();
+ await handleCompleted();
}
return popupClosed;
@@ -149,7 +149,7 @@ export const useProductionConnection = () => {
};
export const useManualConnection = () => {
- const { handleError, handleSuccess, createErrorNotice } =
+ const { handleFailed, handleCompleted, createErrorNotice } =
useConnectionBase();
const { withActivity } = CommonHooks.useBusyState();
const {
@@ -179,9 +179,9 @@ export const useManualConnection = () => {
const res = await connectViaIdAndSecret();
if ( res.success ) {
- await handleSuccess();
+ await handleCompleted();
} else {
- handleError( res, MESSAGES.MANUAL_ERROR );
+ handleFailed( res, MESSAGES.MANUAL_ERROR );
}
return res.success;