moodle/moodle
moodle/moodle
2
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-08-28 08:31:53 +08:00
Code Issues Projects Packages Wiki Activity Actions

MDL-66968 php74: array_key_exists() for objects is deprecated

Browse source 
Replace it for correct property_exists() when the element
being inspected is a property of object/class.

Amended and squased changes:
- keep mongo unmodified. The information is array, hence correct.
- fix a couple of messaging phpdocs that were incorrect.

Amended take#2:
- As far as mongo resturns BSONDocument that is ArrayObject, aka
implements ArrayAccess, we have decided to explicitly cast results
to array so existing array_key_exists() and other accesses will
continue working the same.
This commit is contained in:
Eloy Lafuente (stronk7) 2019-10-20 18:14:48 +02:00
parent aaff6692a1
commit f4feabb83f
21 changed files with 36 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
competency/classes/api.php
View file

@ -3839,7 +3839,7 @@ class api {
if (!$userevidence->can_manage()) {
throw new required_capability_exception($context, 'moodle/competency:userevidencemanage', 'nopermissions', '');
} else if (array_key_exists('userid', $data) && $data->userid != $userevidence->get('userid')) {
} else if (property_exists($data, 'userid') && $data->userid != $userevidence->get('userid')) {
throw new coding_exception('Can not change the userid of a user evidence.');
}