From 737db8daa2445be469a2d9307e57713ea2ac79b6 Mon Sep 17 00:00:00 2001 From: thanghv Date: Mon, 18 May 2020 20:15:34 +0700 Subject: [PATCH] Refactoring --- class/class-mainwp-child-branding.php | 34 +-- class/class-mainwp-child-ithemes-security.php | 14 +- .../class-mainwp-child-server-information.php | 3 +- class/class-mainwp-client-report.php | 262 +++++++++--------- class/class-mainwp-clone.php | 151 +++++----- class/class-mainwp-helper.php | 5 +- 6 files changed, 245 insertions(+), 224 deletions(-) diff --git a/class/class-mainwp-child-branding.php b/class/class-mainwp-child-branding.php index c3b8c56..ad44ccd 100644 --- a/class/class-mainwp-child-branding.php +++ b/class/class-mainwp-child-branding.php @@ -146,9 +146,9 @@ class MainWP_Child_Branding { 'authoruri' => $settings['child_plugin_author_uri'], 'pluginuri' => isset( $settings['child_plugin_uri'] ) ? $settings['child_plugin_uri'] : '', ); - - $current_settings['preserve_branding'] = $settings['child_preserve_branding']; $current_settings['branding_header'] = $header; + + $current_settings['preserve_branding'] = $settings['child_preserve_branding']; $current_settings['support_email'] = $settings['child_support_email']; $current_settings['support_message'] = $settings['child_support_message']; $current_settings['remove_restore'] = $settings['child_remove_restore']; @@ -162,11 +162,23 @@ class MainWP_Child_Branding { $current_settings['email_message'] = $settings['child_send_email_message']; $current_settings['return_sender'] = $settings['child_message_return_sender']; $current_settings['submit_button_title'] = $settings['child_submit_button_title']; - + $current_settings['hide'] = $settings['child_plugin_hide'] ? 'T' : ''; + $current_settings['show_support'] = ( $settings['child_show_support_button'] && ! empty( $settings['child_support_email'] ) ) ? 'T' : ''; + $current_settings['disable_change'] = $settings['child_disable_change'] ? 'T' : ''; + $current_settings['disable_switching_theme'] = $settings['child_disable_switching_theme'] ? 'T' : ''; if ( isset( $settings['child_disable_wp_branding'] ) && ( 'Y' === $settings['child_disable_wp_branding'] || 'N' === $settings['child_disable_wp_branding'] ) ) { $current_settings['disable_wp_branding'] = $settings['child_disable_wp_branding']; } + $current_settings['extra_settings'] = self::get_extra_settings( $current_extra_setting, $settings, $information ); + MainWP_Helper::update_option( 'mainwp_child_branding_settings', $current_settings ); + $information['result'] = 'SUCCESS'; + + return $information; + } + + public static function get_extra_settings( $current_extra_setting, $settings, &$information ){ + $extra_setting = array( 'show_button_in' => $settings['child_show_support_button_in'], 'global_footer' => $settings['child_global_footer'], @@ -255,21 +267,9 @@ class MainWP_Child_Branding { } elseif ( isset( $current_extra_setting['favico_image'] ) ) { $extra_setting['favico_image'] = $current_extra_setting['favico_image']; } - - $current_settings['extra_settings'] = $extra_setting; - - $current_settings['hide'] = $settings['child_plugin_hide'] ? 'T' : ''; - $current_settings['show_support'] = ( $settings['child_show_support_button'] && ! empty( $settings['child_support_email'] ) ) ? 'T' : ''; - $current_settings['disable_change'] = $settings['child_disable_change'] ? 'T' : ''; - $current_settings['disable_switching_theme'] = $settings['child_disable_switching_theme'] ? 'T' : ''; - - MainWP_Helper::update_option( 'mainwp_child_branding_settings', $current_settings ); - - $information['result'] = 'SUCCESS'; - - return $information; + return $extra_setting; } - + public static function branding_upload_image( $img_url ) { include_once ABSPATH . 'wp-admin/includes/file.php'; diff --git a/class/class-mainwp-child-ithemes-security.php b/class/class-mainwp-child-ithemes-security.php index 12426a3..979dc46 100644 --- a/class/class-mainwp-child-ithemes-security.php +++ b/class/class-mainwp-child-ithemes-security.php @@ -13,7 +13,7 @@ * Extension URL: https://mainwp.com/extension/ithemes-security/ */ -// phpcs:disable PSR1.Classes.ClassDeclaration, WordPress.WP.AlternativeFunctions -- root namespace to use external code. +// phpcs:disable -- third party credit code. class MainWP_Child_IThemes_Security { public static $instance = null; @@ -1000,8 +1000,13 @@ class MainWP_Child_IThemes_Security { $active = ''; } - $results = $wpdb->get_results( 'SELECT * FROM `' . $wpdb->base_prefix . 'itsec_lockouts`' . $where . $type_statement . $active . ';', ARRAY_A ); // phpcs:ignore -- safe query. $output = array(); + + return $this->get_lockouts_int( $results, $type ); + } + + private function get_lockouts_int( $results, $type ){ + if ( is_array( $results ) && count( $results ) > 0 ) { switch ( $type ) { case 'host': @@ -1035,10 +1040,11 @@ class MainWP_Child_IThemes_Security { break; } } - + return $output; + } - + public function release_lockout() { global $wpdb; diff --git a/class/class-mainwp-child-server-information.php b/class/class-mainwp-child-server-information.php index e70cdbf..2c2002c 100644 --- a/class/class-mainwp-child-server-information.php +++ b/class/class-mainwp-child-server-information.php @@ -428,10 +428,9 @@ class MainWP_Child_Server_Information { -