Internal: Simplify HTML structure and CSS inside Elementor Editor panels [ED-13157] (#360)

* Internal: Simplify HTML structure and CSS inside Elementor Editor panels

* Fix lint

* Update strings - the theme builder is not new
This commit is contained in:
Rami Yushuvaev 2023-12-20 08:51:51 -08:00 committed by GitHub
parent adcc4faaff
commit 8eba6620d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 41 additions and 67 deletions

View file

@ -6,27 +6,15 @@


&.elementor-nerd-box { &.elementor-nerd-box {


.elementor-nerd-box-icon { .elementor-nerd-box-title {
margin: 0; margin-block-start: 24px;
} }


.elementor-nerd-box-message { .elementor-nerd-box-message {

margin-block-start: 12px;
.elementor-nerd-box-title {
margin: 0;
margin-block-start: 24px;
font-size: 16px;
}

.elementor-nerd-box-message {
margin: 0;
margin-block-start: 12px;
font-size: 11px;
}
} }


.elementor-nerd-box-link { .elementor-nerd-box-link {
margin: 0;
margin-block-start: 24px; margin-block-start: 24px;
} }
} }

View file

@ -499,38 +499,31 @@ class Settings_Footer extends Tab_Base {
} }


public function get_additional_tab_content() { public function get_additional_tab_content() {
$content_template = '
<div class="hello-elementor elementor-nerd-box">
<img src="%1$s" class="elementor-nerd-box-icon">
<p class="elementor-nerd-box-title">%2$s</p>
<p class="elementor-nerd-box-message">%3$s</p>
<a class="elementor-nerd-box-link elementor-button" target="_blank" href="%4$s">%5$s</a>
</div>';

if ( ! defined( 'ELEMENTOR_PRO_VERSION' ) ) { if ( ! defined( 'ELEMENTOR_PRO_VERSION' ) ) {
return sprintf( ' return sprintf(
<div class="hello-elementor elementor-nerd-box"> $content_template,
<img src="%4$s" class="elementor-nerd-box-icon"> get_template_directory_uri() . '/assets/images/go-pro.svg',
<div class="elementor-nerd-box-message">
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
<p>%2$s</p>
</div>
<a class="elementor-button go-pro" target="_blank" href="https://go.elementor.com/hello-theme-footer/">%3$s</a>
</div>
',
esc_html__( 'Create a custom footer with multiple options', 'hello-elementor' ), esc_html__( 'Create a custom footer with multiple options', 'hello-elementor' ),
esc_html__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ), esc_html__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ),
esc_html__( 'Upgrade', 'hello-elementor' ), 'https://go.elementor.com/hello-theme-footer/',
get_template_directory_uri() . '/assets/images/go-pro.svg' esc_html__( 'Upgrade', 'hello-elementor' )
); );
} else { } else {
return sprintf( ' return sprintf(
<div class="hello-elementor elementor-nerd-box"> $content_template,
<img src="%4$s" class="elementor-nerd-box-icon">
<div class="elementor-nerd-box-message">
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
<p class="elementor-nerd-box-message">%2$s</p>
</div>
<a class="elementor-button e-primary" target="_blank" href="%5$s">%3$s</a>
</div>
',
esc_html__( 'Create a custom footer with the new Theme Builder', 'hello-elementor' ),
esc_html__( 'With the new Theme Builder you can jump directly into each part of your site', 'hello-elementor' ),
esc_html__( 'Create Footer', 'hello-elementor' ),
get_template_directory_uri() . '/assets/images/go-pro.svg', get_template_directory_uri() . '/assets/images/go-pro.svg',
get_admin_url( null, 'admin.php?page=elementor-app#/site-editor/templates/footer' ) esc_html__( 'Create a custom footer with the Theme Builder', 'hello-elementor' ),
esc_html__( 'With the Theme Builder you can jump directly into each part of your site', 'hello-elementor' ),
get_admin_url( null, 'admin.php?page=elementor-app#/site-editor/templates/footer' ),
esc_html__( 'Create Footer', 'hello-elementor' )
); );
} }
} }

View file

@ -521,38 +521,31 @@ class Settings_Header extends Tab_Base {
} }


public function get_additional_tab_content() { public function get_additional_tab_content() {
$content_template = '
<div class="hello-elementor elementor-nerd-box">
<img src="%1$s" class="elementor-nerd-box-icon">
<p class="elementor-nerd-box-title">%2$s</p>
<p class="elementor-nerd-box-message">%3$s</p>
<a class="elementor-nerd-box-link elementor-button" target="_blank" href="%4$s">%5$s</a>
</div>';

if ( ! defined( 'ELEMENTOR_PRO_VERSION' ) ) { if ( ! defined( 'ELEMENTOR_PRO_VERSION' ) ) {
return sprintf( ' return sprintf(
<div class="hello-elementor elementor-nerd-box"> $content_template,
<img src="%4$s" class="elementor-nerd-box-icon"> get_template_directory_uri() . '/assets/images/go-pro.svg',
<div class="elementor-nerd-box-message">
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
<p>%2$s</p>
</div>
<a class="elementor-button go-pro" target="_blank" href="https://go.elementor.com/hello-theme-header/">%3$s</a>
</div>
',
esc_html__( 'Create a custom header with multiple options', 'hello-elementor' ), esc_html__( 'Create a custom header with multiple options', 'hello-elementor' ),
esc_html__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ), esc_html__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ),
esc_html__( 'Upgrade', 'hello-elementor' ), 'https://go.elementor.com/hello-theme-header/',
get_template_directory_uri() . '/assets/images/go-pro.svg' esc_html__( 'Upgrade', 'hello-elementor' )
); );
} else { } else {
return sprintf( ' return sprintf(
<div class="hello-elementor elementor-nerd-box"> $content_template,
<img src="%4$s" class="elementor-nerd-box-icon">
<div class="elementor-nerd-box-message">
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
<p class="elementor-nerd-box-message">%2$s</p>
</div>
<a class="elementor-button e-primary" target="_blank" href="%5$s">%3$s</a>
</div>
',
esc_html__( 'Create a custom header with the new Theme Builder', 'hello-elementor' ),
esc_html__( 'With the new Theme Builder you can jump directly into each part of your site', 'hello-elementor' ),
esc_html__( 'Create Header', 'hello-elementor' ),
get_template_directory_uri() . '/assets/images/go-pro.svg', get_template_directory_uri() . '/assets/images/go-pro.svg',
get_admin_url( null, 'admin.php?page=elementor-app#/site-editor/templates/header' ) esc_html__( 'Create a custom header with the Theme Builder', 'hello-elementor' ),
esc_html__( 'With the Theme Builder you can jump directly into each part of your site', 'hello-elementor' ),
get_admin_url( null, 'admin.php?page=elementor-app#/site-editor/templates/header' ),
esc_html__( 'Create Header', 'hello-elementor' )
); );
} }
} }