mirror of
https://ghfast.top/https://github.com/discourse/discourse-translator.git
synced 2026-07-16 11:46:33 +08:00
7fc45d5be8
Currently, `Topic` and `Post` have detected_language and translations in custom fields, e.g.
```
post.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]
post.custom_fields[DiscourseTranslator::TRANSLATED_CUSTOM_FIELD]
topic.custom_fields[DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]
topic.custom_fields[DiscourseTranslator::TRANSLATED_CUSTOM_FIELD]
```
We are moving this into 4 tables/models
```
post has_one :content_locale, class_name: "DiscourseTranslator::PostLocale"
post has_many :translations, class_name: "DiscourseTranslator::PostTranslation"
topic has_one :content_locale, class_name: "DiscourseTranslator::TopicLocale"
topic has_many :translations, class_name: "DiscourseTranslator::TopicTranslation"
```
Since there are a lot of duplicates, this is implemented on the `Post` and `Topic` using a `Concern`, and any future translatable content can inherit this concern.
This PR also gets rid of the previous N+1 which happens when determining if the 🌐 translate button should appear for each post.
74 lines
2.1 KiB
Ruby
74 lines
2.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "rails_helper"
|
|
|
|
RSpec.describe DiscourseTranslator::Amazon do
|
|
let(:mock_response) { Struct.new(:status, :body) }
|
|
|
|
describe ".truncate" do
|
|
it "truncates text to 10000 bytes" do
|
|
text = "こんにちは" * (described_class::MAX_BYTES / 5)
|
|
truncated = described_class.truncate(text)
|
|
|
|
expect(truncated.bytesize).to be <= described_class::MAX_BYTES
|
|
expect(truncated.valid_encoding?).to eq(true)
|
|
expect(truncated[-1]).to eq "に"
|
|
end
|
|
end
|
|
|
|
describe ".detect" do
|
|
let(:post) { Fabricate(:post) }
|
|
let!(:client) { Aws::Translate::Client.new(stub_responses: true) }
|
|
let(:text) { described_class.truncate(post.cooked) }
|
|
let(:detected_lang) { "en" }
|
|
|
|
before do
|
|
client.stub_responses(
|
|
:translate_text,
|
|
{
|
|
translated_text: "Probando traducciones",
|
|
source_language_code: "en",
|
|
target_language_code: "es",
|
|
},
|
|
)
|
|
Aws::Translate::Client.stubs(:new).returns(client)
|
|
end
|
|
|
|
it "should store the detected language in a custom field" do
|
|
expect(described_class.detect(post)).to eq(detected_lang)
|
|
|
|
expect(post.detected_locale).to eq(detected_lang)
|
|
end
|
|
|
|
it "should fail graciously when the cooked translated text is blank" do
|
|
post.cooked = ""
|
|
expect(described_class.detect(post)).to be_nil
|
|
end
|
|
end
|
|
|
|
describe ".translate" do
|
|
let(:post) { Fabricate(:post) }
|
|
let!(:client) { Aws::Translate::Client.new(stub_responses: true) }
|
|
|
|
before do
|
|
client.stub_responses(
|
|
:translate_text,
|
|
"UnsupportedLanguagePairException",
|
|
{
|
|
translated_text: "Probando traducciones",
|
|
source_language_code: "en",
|
|
target_language_code: "es",
|
|
},
|
|
)
|
|
described_class.stubs(:client).returns(client)
|
|
post.set_detected_locale("en")
|
|
I18n.stubs(:locale).returns(:es)
|
|
end
|
|
|
|
it "raises an error when trying to translate an unsupported language" do
|
|
expect { described_class.translate(post) }.to raise_error(
|
|
I18n.t("translator.failed", source_locale: "en", target_locale: "es"),
|
|
)
|
|
end
|
|
end
|
|
end
|
