mirror of
https://ghfast.top/https://github.com/discourse/discourse-translator.git
synced 2026-07-17 11:56:50 +08:00
cdb3a59b8a
In the older implementation of translation, there exists these two site settings are part of the criteria that determines if 🌐 shows up per post * `restrict translation by group` - Only allowed groups can translate * `restrict translation by poster group` - Only allow translation of posts made by users in allowed groups. If empty, allow translations of posts from all users. In a recent update with experimental features, we updated the cases where 🌐 will show up and caused a regression where the 🌐 shows up for everyone in `restrict translation by group`, ignoring `restrict translation by poster group`. This commit makes sure these two site settings are adhered to when the experimental topic setting is turned off.
105 lines
3.6 KiB
Ruby
105 lines
3.6 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require "rails_helper"
|
|
|
|
RSpec.describe PostSerializer do
|
|
fab!(:group)
|
|
fab!(:user) { Fabricate(:user, locale: "en", groups: [group]) }
|
|
|
|
fab!(:post_user_group) { Fabricate(:group) }
|
|
fab!(:post_user) { Fabricate(:user, locale: "en", groups: [post_user_group]) }
|
|
fab!(:post) { Fabricate(:post, user: post_user) }
|
|
|
|
describe "#can_translate" do
|
|
it "returns false when translator disabled" do
|
|
SiteSetting.translator_enabled = false
|
|
serializer = PostSerializer.new(post, scope: Guardian.new)
|
|
|
|
expect(serializer.can_translate).to eq(false)
|
|
end
|
|
|
|
describe "when translator enabled" do
|
|
before do
|
|
SiteSetting.translator_enabled = true
|
|
SiteSetting.restrict_translation_by_group = "#{Group::AUTO_GROUPS[:everyone]}"
|
|
SiteSetting.restrict_translation_by_poster_group = ""
|
|
end
|
|
let(:serializer) { PostSerializer.new(post, scope: Guardian.new) }
|
|
|
|
it "cannot translate for anon" do
|
|
expect(serializer.can_translate).to eq(false)
|
|
end
|
|
|
|
describe "logged in user" do
|
|
let(:serializer) { PostSerializer.new(post, scope: Guardian.new(user)) }
|
|
|
|
it "cannot translate when user is not in restrict_translation_by_group" do
|
|
SiteSetting.restrict_translation_by_group = "#{group.id + 1}"
|
|
|
|
expect(serializer.can_translate).to eq(false)
|
|
end
|
|
|
|
describe "user is in restrict_translation_by_group" do
|
|
describe "post author in restrict_translation_by_poster_group and locale is :xx" do
|
|
it "can translate when post detected locale does not match i18n locale" do
|
|
SiteSetting.restrict_translation_by_group = "#{group.id}"
|
|
SiteSetting.restrict_translation_by_poster_group = "#{post_user_group.id}"
|
|
I18n.stubs(:locale).returns(:pt)
|
|
|
|
post.set_detected_locale("jp")
|
|
|
|
expect(serializer.can_translate).to eq(true)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#cooked" do
|
|
def serialize_post(guardian_user: user, params: {})
|
|
env = { "action_dispatch.request.parameters" => params, "REQUEST_METHOD" => "GET" }
|
|
request = ActionDispatch::Request.new(env)
|
|
guardian = Guardian.new(guardian_user, request)
|
|
PostSerializer.new(post, scope: guardian)
|
|
end
|
|
|
|
before do
|
|
SiteSetting.translator_enabled = true
|
|
SiteSetting.experimental_topic_translation = true
|
|
end
|
|
|
|
it "does not return translated_cooked when experimental_topic_translation is disabled" do
|
|
SiteSetting.experimental_topic_translation = false
|
|
expect(serialize_post.cooked).to eq(post.cooked)
|
|
end
|
|
|
|
it "does not return translated_cooked when show=original param is present" do
|
|
I18n.locale = "ja"
|
|
post.set_translation("ja", "こんにちは")
|
|
|
|
expect(serialize_post(params: { "show" => "original" }).cooked).to eq(post.cooked)
|
|
expect(serialize_post(params: { "show" => "derp" }).cooked).to eq("こんにちは")
|
|
end
|
|
|
|
it "does not return translated_cooked when post is already in correct locale" do
|
|
I18n.locale = "ja"
|
|
post.set_detected_locale("ja")
|
|
post.set_translation("ja", "こんにちは")
|
|
|
|
expect(serialize_post.cooked).to eq(post.cooked)
|
|
end
|
|
|
|
it "returns translated content based on locale" do
|
|
I18n.locale = "ja"
|
|
post.set_translation("ja", "こんにちは")
|
|
post.set_translation("es", "Hola")
|
|
expect(serialize_post.cooked).to eq("こんにちは")
|
|
end
|
|
|
|
it "does not return translated_cooked when plugin is disabled" do
|
|
SiteSetting.translator_enabled = false
|
|
expect(serialize_post.cooked).to eq(post.cooked)
|
|
end
|
|
end
|
|
end
|
