discourse-translator/spec/services/amazon_spec.rb
Régis Hanol 60ab557173
FIX: Amazon text size is 10k bytes (#137)
The Amazon translate API allows for a text to be up to 10k bytes.

This changes the `MAXLENGTH` constant into the `MAX_BYTES` and uses a `truncate` method that works at the bytes level instead of the character/grapheme level.

Ref - https://meta.discourse.org/t/increase-amazon-translate-limit-to-10-000-characters/304579
2024-04-19 16:01:06 +02:00

74 lines
2.1 KiB
Ruby

# frozen_string_literal: true
require "rails_helper"
RSpec.describe DiscourseTranslator::Amazon do
let(:mock_response) { Struct.new(:status, :body) }
describe ".truncate" do
it "truncates text to 10000 bytes" do
text = "こんにちは" * (described_class::MAX_BYTES / 5)
truncated = described_class.truncate(text)
expect(truncated.bytesize).to be <= described_class::MAX_BYTES
expect(truncated.valid_encoding?).to eq(true)
expect(truncated[-1]).to eq ""
end
end
describe ".detect" do
let(:post) { Fabricate(:post) }
let!(:client) { Aws::Translate::Client.new(stub_responses: true) }
let(:text) { described_class.truncate(post.cooked) }
let(:detected_lang) { "en" }
before do
client.stub_responses(
:translate_text,
{
translated_text: "Probando traducciones",
source_language_code: "en",
target_language_code: "es",
},
)
Aws::Translate::Client.stubs(:new).returns(client)
end
it "should store the detected language in a custom field" do
expect(described_class.detect(post)).to eq(detected_lang)
2.times do
expect(post.custom_fields[::DiscourseTranslator::DETECTED_LANG_CUSTOM_FIELD]).to eq(
detected_lang,
)
end
end
it "should fail graciously when the cooked translated text is blank" do
post.cooked = ""
expect(described_class.detect(post)).to be_nil
end
end
describe ".translate" do
let(:post) { Fabricate(:post) }
let!(:client) { Aws::Translate::Client.new(stub_responses: true) }
before do
client.stub_responses(
:translate_text,
"UnsupportedLanguagePairException",
{
translated_text: "Probando traducciones",
source_language_code: "en",
target_language_code: "es",
},
)
described_class.stubs(:client).returns(client)
end
it "raises an error when trying to translate an unsupported language" do
expect { described_class.translate(post) }.to raise_error(I18n.t("translator.failed"))
end
end
end