discourse-akismet/spec/models/reviewable_akismet_post_spec.rb
Roman Rizzi 6247614cfb
FIX: Submit feedback correctly (#39)
* FIX: Submit feedback in every case and avoid a race condition when submitting feedback/deleting an user

* Update spec/models/reviewable_akismet_user_spec.rb

Co-Authored-By: Robin Ward <robin.ward@gmail.com>

* Update spec/models/reviewable_akismet_post_spec.rb

Co-Authored-By: Robin Ward <robin.ward@gmail.com>
2019-06-07 14:35:09 -03:00

203 lines
5.9 KiB
Ruby

# frozen_string_literal: true
require 'rails_helper'
describe 'ReviewableAkismetPost', if: defined?(Reviewable) do
let(:guardian) { Guardian.new }
describe '#build_actions' do
let(:reviewable) { ReviewableAkismetPost.new }
it 'Does not return available actions when the reviewable is no longer pending' do
available_actions = (Reviewable.statuses.keys - [:pending]).reduce([]) do |actions, status|
reviewable.status = Reviewable.statuses[status]
an_action_id = :confirm_spam
actions.concat reviewable_actions(guardian).to_a
end
expect(available_actions).to be_empty
end
it 'Adds the confirm spam action' do
actions = reviewable_actions(guardian)
expect(actions.has?(:confirm_spam)).to be true
end
it 'Adds the not spam action' do
actions = reviewable_actions(guardian)
expect(actions.has?(:not_spam)).to be true
end
it 'Adds the dismiss action' do
actions = reviewable_actions(guardian)
expect(actions.has?(:ignore)).to be true
end
it 'Adds the confirm delete action' do
admin = Fabricate(:admin)
guardian = Guardian.new(admin)
actions = reviewable_actions(guardian)
expect(actions.has?(:confirm_delete)).to be true
end
it 'Excludes the confirm delete action when the user is not an staff member' do
actions = reviewable_actions(guardian)
expect(actions.has?(:confirm_delete)).to be false
end
def reviewable_actions(guardian)
actions = Reviewable::Actions.new(reviewable, guardian, {})
reviewable.build_actions(actions, guardian, {})
actions
end
end
describe 'Performing actions on reviewable' do
let(:admin) { Fabricate(:admin) }
let(:post) { Fabricate(:post) }
let(:reviewable) { ReviewableAkismetPost.needs_review!(target: post, created_by: admin).reload }
before do
post.trash!(admin)
end
shared_examples 'It logs actions in the staff actions logger' do
it 'Creates a UserHistory that reflects the action taken' do
reviewable.perform admin, action
admin_last_action = UserHistory.find_by(post: post)
assert_history_reflects_action(admin_last_action, admin, post, action_name)
end
def assert_history_reflects_action(action, admin, post, action_name)
expect(action.custom_type).to eq action_name
expect(action.post_id).to eq post.id
expect(action.topic_id).to eq post.topic_id
end
it 'Returns necessary information to update reviewable creator user stats' do
result = reviewable.perform admin, action
update_flag_stats = result.update_flag_stats
expect(update_flag_stats[:status]).to eq flag_stat_status
expect(update_flag_stats[:user_ids]).to match_array [reviewable.created_by_id]
end
end
shared_examples 'it submits feedback to Akismet' do
it 'queues a job to submit feedback' do
expect {
reviewable.perform admin, action
}.to change(Jobs::UpdateAkismetStatus.jobs, :size).by(1)
end
end
describe '#perform_confirm_spam' do
let(:action) { :confirm_spam }
let(:action_name) { 'confirmed_spam' }
let(:flag_stat_status) { :agreed }
it_behaves_like 'It logs actions in the staff actions logger'
it_behaves_like 'it submits feedback to Akismet'
it 'Confirms spam and reviewable status is changed to approved' do
result = reviewable.perform admin, action
expect(result.transition_to).to eq :approved
end
end
describe '#perform_not_spam' do
let(:action) { :not_spam }
let(:action_name) { 'confirmed_ham' }
let(:flag_stat_status) { :disagreed }
it_behaves_like 'It logs actions in the staff actions logger'
it_behaves_like 'it submits feedback to Akismet'
it 'Set post as clear and reviewable status is changed to rejected' do
result = reviewable.perform admin, action
expect(result.transition_to).to eq :rejected
end
it 'Sends feedback to Akismet since post was not spam' do
expect {
reviewable.perform admin, action
}.to change(Jobs::UpdateAkismetStatus.jobs, :size).by(1)
end
it 'Recovers the post' do
reviewable.perform admin, action
recovered_post = post.reload
expect(recovered_post.deleted_at).to be_nil
expect(recovered_post.deleted_by).to be_nil
end
it 'Does not try to recover the post if it was already recovered' do
post.update(deleted_at: nil)
event_triggered = false
DiscourseEvent.on(:post_recovered) { event_triggered = true }
reviewable.perform admin, action
expect(event_triggered).to eq false
end
end
describe '#perform_ignore' do
let(:action) { :ignore }
let(:action_name) { 'ignored' }
let(:flag_stat_status) { :ignored }
it_behaves_like 'It logs actions in the staff actions logger'
it 'Set post as dismissed and reviewable status is changed to ignored' do
result = reviewable.perform admin, action
expect(result.transition_to).to eq :ignored
end
end
describe '#perform_confirm_delete' do
let(:action) { :confirm_delete }
let(:action_name) { 'confirmed_spam_deleted' }
let(:flag_stat_status) { :agreed }
it_behaves_like 'It logs actions in the staff actions logger'
it_behaves_like 'it submits feedback to Akismet'
it 'Confirms spam and reviewable status is changed to deleted' do
result = reviewable.perform admin, action
expect(result.transition_to).to eq :deleted
end
it 'Deletes the user' do
reviewable.perform admin, action
expect(post.reload.user).to be_nil
end
it 'Does not delete the user when it cannot be deleted' do
post.update(user: admin)
reviewable.perform admin, action
expect(post.reload.user).to be_present
end
end
end
end