mirror of
https://ghfast.top/https://github.com/discourse/discourse-akismet.git
synced 2026-07-15 11:36:24 +08:00
Some checks failed
Discourse Plugin / ci (push) Has been cancelled
The staff action log records moderation actions (post deletions, user approvals, etc.) as `UserHistory` rows, but entries triggered from the reviewable queue had no reference back to the reviewable that caused them. When auditing a decision in the log, staff could not jump to the Akismet flag that produced it. Core PR must be merged first: https://github.com/discourse/discourse/pull/39519 It adds a `reviewable:` option to `StaffActionLogger#new` that persists the reviewable id on the resulting `UserHistory` record.
186 lines
5.7 KiB
Ruby
186 lines
5.7 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "ReviewableAkismetUser" do
|
|
let(:guardian) { Guardian.new }
|
|
|
|
before { SiteSetting.akismet_enabled = true }
|
|
|
|
describe "#build_actions" do
|
|
let(:reviewable) { ReviewableAkismetUser.new }
|
|
|
|
it "does not return available actions when the reviewable is no longer pending" do
|
|
available_actions =
|
|
(Reviewable.statuses.symbolize_keys.keys - [:pending]).reduce([]) do |actions, status|
|
|
reviewable.status = Reviewable.statuses[status]
|
|
an_action_id = :not_spam
|
|
|
|
actions.concat reviewable_actions(guardian).to_a
|
|
end
|
|
|
|
expect(available_actions).to be_empty
|
|
end
|
|
|
|
it "adds the not spam action" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:not_spam)).to be true
|
|
end
|
|
|
|
it "adds the delete and delete + block actions" do
|
|
admin = Fabricate(:admin)
|
|
guardian = Guardian.new(admin)
|
|
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:delete_user)).to be true
|
|
expect(actions.has?(:delete_user_block)).to be true
|
|
end
|
|
|
|
it "excludes the delete actions when the user is not an staff member" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:delete_user)).to be false
|
|
expect(actions.has?(:delete_user_block)).to be false
|
|
end
|
|
|
|
def reviewable_actions(guardian)
|
|
actions = Reviewable::Actions.new(reviewable, guardian, {})
|
|
reviewable.build_actions(actions, guardian, {})
|
|
|
|
actions
|
|
end
|
|
end
|
|
|
|
describe "performing actions on reviewable" do
|
|
let(:admin) { Fabricate(:admin) }
|
|
|
|
let(:user) do
|
|
Fabricate(:user, trust_level: TrustLevel[0]).tap do |user|
|
|
user.user_profile.bio_raw = "I am batman"
|
|
user.user_auth_token_logs = [
|
|
UserAuthTokenLog.new(client_ip: "127.0.0.1", action: "an_action"),
|
|
]
|
|
end
|
|
end
|
|
|
|
let(:reviewable) { ReviewableAkismetUser.needs_review!(target: user, created_by: admin) }
|
|
|
|
before { UserAuthToken.generate!(user_id: user.id) }
|
|
|
|
shared_examples "a staff action logger" do
|
|
it "creates a UserHistory that reflects the action taken" do
|
|
reviewable.perform admin, action
|
|
|
|
admin_last_action = UserHistory.find_by!(acting_user_id: admin)
|
|
|
|
assert_history_reflects_action(admin_last_action, admin, action_name)
|
|
end
|
|
|
|
def assert_history_reflects_action(action, admin, action_name)
|
|
expect(action.custom_type).to eq action_name
|
|
expect(action.acting_user).to eq admin
|
|
expect(action.reviewable_id).to eq reviewable.id
|
|
end
|
|
|
|
it "returns necessary information to update reviewable creator user stats" do
|
|
result = reviewable.perform admin, action
|
|
|
|
update_flag_stats = result.update_flag_stats
|
|
|
|
expect(update_flag_stats[:status]).to eq flag_stat_status
|
|
expect(update_flag_stats[:user_ids]).to match_array [reviewable.created_by_id]
|
|
end
|
|
end
|
|
|
|
shared_examples "an Akismet feedback submission" do
|
|
it "queues a job to submit feedback" do
|
|
expect { reviewable.perform admin, action }.to change(
|
|
Jobs::UpdateAkismetStatus.jobs,
|
|
:size,
|
|
).by(1)
|
|
end
|
|
end
|
|
|
|
describe "#perform_not_spam" do
|
|
let(:action) { :not_spam }
|
|
let(:action_name) { "confirmed_ham" }
|
|
let(:flag_stat_status) { :disagreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "sets post as clear and reviewable status is changed to rejected" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :rejected
|
|
end
|
|
end
|
|
|
|
describe "#perform_delete_user" do
|
|
let(:action) { :delete_user }
|
|
let(:action_name) { "confirmed_spam_deleted" }
|
|
let(:flag_stat_status) { :agreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "confirms spam and reviewable status is changed to deleted" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :deleted
|
|
end
|
|
|
|
it "deletes the user" do
|
|
reviewable.perform admin, action
|
|
|
|
expect { user.reload }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
end
|
|
|
|
describe "#perform_delete_user_block" do
|
|
let(:action) { :delete_user_block }
|
|
let(:action_name) { "confirmed_spam_deleted" }
|
|
let(:flag_stat_status) { :agreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "confirms spam and reviewable status is changed to deleted" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :deleted
|
|
end
|
|
|
|
it "deletes the user" do
|
|
reviewable.perform admin, action
|
|
|
|
expect { user.reload }.to raise_error(ActiveRecord::RecordNotFound)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "deleting existing flagged posts for a flagged user" do
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:user) { Fabricate(:user) }
|
|
let(:reviewable) { ReviewableAkismetUser.needs_review!(target: user, created_by: admin) }
|
|
|
|
before { UserAuthToken.generate!(user_id: user.id) }
|
|
|
|
it "queues a job to approve existing Akismet flagged posts" do
|
|
expect { reviewable.perform(admin, :delete_user) }.to change(
|
|
Jobs::ConfirmAkismetFlaggedPosts.jobs,
|
|
:size,
|
|
).by(1)
|
|
end
|
|
|
|
it "approved flagged posts by the flagged user" do
|
|
flagged_post = Fabricate(:post, user: user)
|
|
flagged_post_reviewable =
|
|
ReviewableFlaggedPost.needs_review!(target: flagged_post, created_by: admin)
|
|
|
|
reviewable.perform admin, :delete_user
|
|
|
|
expect(flagged_post_reviewable.reload).to be_approved
|
|
end
|
|
end
|
|
end
|