mirror of
https://ghfast.top/https://github.com/discourse/discourse-akismet.git
synced 2026-07-15 11:36:24 +08:00
4a3338e2a8
Some checks failed
Discourse Plugin / ci (push) Has been cancelled
The staff action log records moderation actions (post deletions, user approvals, etc.) as `UserHistory` rows, but entries triggered from the reviewable queue had no reference back to the reviewable that caused them. When auditing a decision in the log, staff could not jump to the Akismet flag that produced it. Core PR must be merged first: https://github.com/discourse/discourse/pull/39519 It adds a `reviewable:` option to `StaffActionLogger#new` that persists the reviewable id on the resulting `UserHistory` record.
286 lines
9.1 KiB
Ruby
286 lines
9.1 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
describe "ReviewableAkismetPost" do
|
|
let(:guardian) { Guardian.new }
|
|
|
|
before { SiteSetting.akismet_enabled = true }
|
|
|
|
describe "#build_actions" do
|
|
let(:reviewable) { ReviewableAkismetPost.new(target: Fabricate(:post)) }
|
|
|
|
before { reviewable.created_new! }
|
|
|
|
it "Does not return available actions when the reviewable is no longer pending" do
|
|
available_actions =
|
|
(Reviewable.statuses.symbolize_keys.keys - [:pending]).reduce([]) do |actions, status|
|
|
reviewable.status = Reviewable.statuses[status]
|
|
an_action_id = :confirm_spam
|
|
|
|
actions.concat reviewable_actions(guardian).to_a
|
|
end
|
|
|
|
expect(available_actions).to be_empty
|
|
end
|
|
|
|
it "Adds the confirm spam action" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:confirm_spam)).to be true
|
|
end
|
|
|
|
it "Adds the not spam action" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:not_spam)).to be true
|
|
end
|
|
|
|
it "Adds the dismiss action" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:ignore)).to be true
|
|
end
|
|
|
|
it "Adds the delete and delete + block actions" do
|
|
admin = Fabricate(:admin)
|
|
guardian = Guardian.new(admin)
|
|
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:delete_user)).to be true
|
|
expect(actions.has?(:delete_user_block)).to be true
|
|
end
|
|
|
|
it "Excludes the confirm delete action when the user is not an staff member" do
|
|
actions = reviewable_actions(guardian)
|
|
|
|
expect(actions.has?(:confirm_delete)).to be false
|
|
end
|
|
|
|
def reviewable_actions(guardian)
|
|
actions = Reviewable::Actions.new(reviewable, guardian, {})
|
|
reviewable.build_actions(actions, guardian, {})
|
|
|
|
actions
|
|
end
|
|
end
|
|
|
|
describe "Performing actions on reviewable" do
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:post) { Fabricate(:post_with_long_raw_content) }
|
|
let(:reviewable) { ReviewableAkismetPost.needs_review!(target: post, created_by: admin) }
|
|
|
|
before { PostDestroyer.new(admin, post).destroy }
|
|
|
|
shared_examples "a staff action logger" do
|
|
it "Creates a UserHistory that reflects the action taken" do
|
|
reviewable.perform admin, action
|
|
|
|
admin_last_action = UserHistory.find_by(post: post)
|
|
|
|
assert_history_reflects_action(admin_last_action, admin, post, action_name)
|
|
end
|
|
|
|
def assert_history_reflects_action(action, admin, post, action_name)
|
|
expect(action.custom_type).to eq action_name
|
|
expect(action.post_id).to eq post.id
|
|
expect(action.topic_id).to eq post.topic_id
|
|
expect(action.reviewable_id).to eq reviewable.id
|
|
end
|
|
|
|
it "Returns necessary information to update reviewable creator user stats" do
|
|
result = reviewable.perform admin, action
|
|
|
|
update_flag_stats = result.update_flag_stats
|
|
|
|
expect(update_flag_stats[:status]).to eq flag_stat_status
|
|
expect(update_flag_stats[:user_ids]).to match_array [reviewable.created_by_id]
|
|
end
|
|
end
|
|
|
|
shared_examples "an Akismet feedback submission" do
|
|
it "queues a job to submit feedback" do
|
|
expect { reviewable.perform admin, action }.to change(
|
|
Jobs::UpdateAkismetStatus.jobs,
|
|
:size,
|
|
).by(1)
|
|
end
|
|
end
|
|
|
|
describe "#perform_confirm_spam" do
|
|
let(:action) { :confirm_spam }
|
|
let(:action_name) { "confirmed_spam" }
|
|
let(:flag_stat_status) { :agreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "Confirms spam and reviewable status is changed to approved" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :approved
|
|
end
|
|
end
|
|
|
|
describe "#perform_not_spam" do
|
|
let(:action) { :not_spam }
|
|
let(:action_name) { "confirmed_ham" }
|
|
let(:flag_stat_status) { :disagreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "Set post as clear and reviewable status is changed to rejected" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :rejected
|
|
end
|
|
|
|
it "Sends feedback to Akismet since post was not spam" do
|
|
expect { reviewable.perform admin, action }.to change(
|
|
Jobs::UpdateAkismetStatus.jobs,
|
|
:size,
|
|
).by(1)
|
|
end
|
|
|
|
it "Recovers the post" do
|
|
reviewable.perform admin, action
|
|
|
|
recovered_post = post.reload
|
|
|
|
expect(recovered_post.deleted_at).to be_nil
|
|
expect(recovered_post.deleted_by).to be_nil
|
|
end
|
|
|
|
it "Does not try to recover the post if it was already recovered" do
|
|
post.update(deleted_at: nil)
|
|
event_triggered = false
|
|
blk = Proc.new { event_triggered = true }
|
|
|
|
begin
|
|
DiscourseEvent.on(:post_recovered, &blk)
|
|
reviewable.perform admin, action
|
|
|
|
expect(event_triggered).to eq false
|
|
ensure
|
|
DiscourseEvent.off(:post_recovered, &blk)
|
|
end
|
|
end
|
|
|
|
it "Sends a system message to the user" do
|
|
expect { reviewable.perform admin, action }.to change { Topic.private_messages.count }.by(1)
|
|
|
|
pm = Topic.private_messages.last
|
|
expect(pm.allowed_users).to contain_exactly(Discourse.system_user, post.user)
|
|
end
|
|
|
|
it "Does not send a system message to the user if topic is gone" do
|
|
first_post = Fabricate(:post_with_long_raw_content)
|
|
post = Fabricate(:post_with_long_raw_content, topic: first_post.topic)
|
|
PostDestroyer.new(Discourse.system_user, post, context: "test setup").destroy
|
|
reviewable =
|
|
ReviewableAkismetPost.needs_review!(target: post, created_by: Discourse.system_user)
|
|
PostDestroyer.new(Discourse.system_user, first_post, context: "test setup").destroy
|
|
|
|
expect { reviewable.perform admin, action }.not_to change { Topic.private_messages.count }
|
|
end
|
|
end
|
|
|
|
describe "#perform_ignore" do
|
|
let(:action) { :ignore }
|
|
let(:action_name) { "ignored" }
|
|
let(:flag_stat_status) { :ignored }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
|
|
it "Set post as dismissed and reviewable status is changed to ignored" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :ignored
|
|
end
|
|
end
|
|
|
|
describe "#perform_delete_user" do
|
|
let(:action) { :delete_user }
|
|
let(:action_name) { "confirmed_spam_deleted" }
|
|
let(:flag_stat_status) { :agreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "Confirms spam and reviewable status is changed to deleted" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :deleted
|
|
end
|
|
|
|
it "Deletes the user" do
|
|
reviewable.perform admin, action
|
|
|
|
expect(post.reload.user).to be_nil
|
|
end
|
|
|
|
it "Sends email when deleting the user" do
|
|
SiteSetting.simple_email_subject = false if SiteSetting.respond_to?(:simple_email_subject)
|
|
|
|
expect { reviewable.perform(admin, action) }.to change {
|
|
ActionMailer::Base.deliveries.count
|
|
}
|
|
expect(ActionMailer::Base.deliveries.last.to).to eq([post.user.email])
|
|
expect(ActionMailer::Base.deliveries.last.subject).to include(
|
|
I18n.t("user_notifications.account_deleted.subject_template", email_prefix: "Discourse"),
|
|
)
|
|
end
|
|
end
|
|
|
|
describe "#perform_delete_user_block" do
|
|
let(:action) { :delete_user_block }
|
|
let(:action_name) { "confirmed_spam_deleted" }
|
|
let(:flag_stat_status) { :agreed }
|
|
|
|
it_behaves_like "a staff action logger"
|
|
it_behaves_like "an Akismet feedback submission"
|
|
|
|
it "Confirms spam and reviewable status is changed to deleted" do
|
|
result = reviewable.perform admin, action
|
|
|
|
expect(result.transition_to).to eq :deleted
|
|
end
|
|
|
|
it "Deletes the user" do
|
|
reviewable.perform admin, action
|
|
|
|
expect(post.reload.user).to be_nil
|
|
end
|
|
|
|
it "Sends email when deleting the user" do
|
|
SiteSetting.simple_email_subject = false if SiteSetting.respond_to?(:simple_email_subject)
|
|
|
|
expect { reviewable.perform(admin, action) }.to change {
|
|
ActionMailer::Base.deliveries.count
|
|
}
|
|
expect(ActionMailer::Base.deliveries.last.to).to eq([post.user.email])
|
|
expect(ActionMailer::Base.deliveries.last.subject).to include(
|
|
I18n.t("user_notifications.account_deleted.subject_template", email_prefix: "Discourse"),
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "Performing actions on reviewable API errors" do
|
|
let(:admin) { Fabricate(:admin) }
|
|
let(:post) { Fabricate(:post_with_long_raw_content) }
|
|
let(:reviewable) { ReviewableAkismetPost.needs_review!(target: post, created_by: admin).reload }
|
|
|
|
describe "#perform_confirm_spam" do
|
|
let(:action) { :confirm_spam }
|
|
|
|
it "Ensures the post has been deleted" do
|
|
reviewable.perform admin, action
|
|
|
|
updated_post = post.reload
|
|
|
|
expect(updated_post.deleted_at).not_to eq(nil)
|
|
end
|
|
end
|
|
end
|
|
end
|
