Merge pull request #2550 from rodrigoprimo/readonly-anonymous-classes

PHP 8.3 readonly anonymous classes: add tests to two sniffs

WordPress/Sniffs/WP/GlobalVariablesOverrideSniff.php

@@ -174,7 +174,7 @@ final class GlobalVariablesOverrideSniff extends Sniff {
 	protected function process_list_assignment( $stackPtr ) {
 		$list_open_close = Lists::getOpenClose( $this->phpcsFile, $stackPtr );
 		if ( false === $list_open_close ) {
-			// Short array, not short list.
+			// Live coding or short array, not short list.
 			return;
 		}
 

WordPress/Tests/NamingConventions/PrefixAllGlobalsUnitTest.1.inc

@@ -137,7 +137,7 @@ class Acronym_Example {
 	function do_something( $param = 'default' ) {}
 }
 
-$acronym_class = new class {
+$acronym_class = new readonly class {
 	const SOME_CONSTANT = 'value';
 
 	public $var = 'abc';
@@ -673,4 +673,14 @@ class WP_Atom_Server {
 	}
 }
 
+/*
+ * Safeguard that PHP 8.4+ asymmetric visibility properties don't lead to false positives.
+ * Including those defined using constructor property promotion.
+ */
+class Acronym_AsymmetricVisibilityProperties {
+    public private(set) string $bar = 'bar'; // Ok.
+
+    public function __construct(public protected(set) int $foo = 0) {} // Ok.
+}
+
 // phpcs:set WordPress.NamingConventions.PrefixAllGlobals prefixes[]

WordPress/Tests/NamingConventions/ValidFunctionNameUnitTest.1.inc

@@ -223,6 +223,11 @@ function lähtöaika() {} // OK.
 function lÄhtÖaika() {} // Bad, but only handled by the sniff if Mbstring is available.
 function lÄhtOaika() {} // Bad, handled via transliteration of non-ASCII chars if Mbstring is not available.
 
-// Live coding/parse error.
-// This has to be the last test in the file.
-function
+/*
+ * Safeguard that PHP 8.3+ readonly anonymous classes are handled correctly.
+ */
+$anon_class = new readonly class() {
+    public function camelCase() {} // Bad.
+    protected function __something() {} // Bad.
+    private function snake_case() {} // Ok.
+};

WordPress/Tests/NamingConventions/ValidFunctionNameUnitTest.2.inc

@@ -0,0 +1,8 @@
+<?php
+
+/*
+ * Intentional parse error (nothing after T_FUNCTION).
+ * This should be the only test in this file.
+ */
+
+function

WordPress/Tests/NamingConventions/ValidFunctionNameUnitTest.php

@@ -25,38 +25,48 @@ final class ValidFunctionNameUnitTest extends AbstractSniffUnitTest {
 	/**
 	 * Returns the lines where errors should occur.
 	 *
+	 * @param string $testFile The name of the file being tested.
+	 *
 	 * @return array<int, int> Key is the line number, value is the number of expected errors.
 	 */
-	public function getErrorList() {
-		return array(
-			3   => 1,
-			9   => 1,
-			13  => 1,
-			15  => 1,
-			79  => 2,
-			80  => 2,
-			81  => 2,
-			82  => 2,
-			83  => 2,
-			84  => 2,
-			85  => 2,
-			86  => 2,
-			87  => 2,
-			88  => 2,
-			89  => 2,
-			106 => 2,
-			116 => 1,
-			117 => 1,
-			157 => 2,
-			183 => 1,
-			184 => 1,
-			185 => 1,
-			199 => 1,
-			208 => 2,
-			210 => 1,
-			223 => function_exists( 'mb_strtolower' ) ? 1 : 0,
-			224 => 1,
-		);
+	public function getErrorList( $testFile = '' ) {
+		switch ( $testFile ) {
+			case 'ValidFunctionNameUnitTest.1.inc':
+				return array(
+					3   => 1,
+					9   => 1,
+					13  => 1,
+					15  => 1,
+					79  => 2,
+					80  => 2,
+					81  => 2,
+					82  => 2,
+					83  => 2,
+					84  => 2,
+					85  => 2,
+					86  => 2,
+					87  => 2,
+					88  => 2,
+					89  => 2,
+					106 => 2,
+					116 => 1,
+					117 => 1,
+					157 => 2,
+					183 => 1,
+					184 => 1,
+					185 => 1,
+					199 => 1,
+					208 => 2,
+					210 => 1,
+					223 => function_exists( 'mb_strtolower' ) ? 1 : 0,
+					224 => 1,
+					230 => 1,
+					231 => 1,
+				);
+
+			default:
+				return array();
+		}
 	}
 
 	/**

WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.inc

@@ -237,3 +237,11 @@ class Has_Mixed_Case_Property {
 $lähtöaika = true; // OK.
 $lÄhtÖaika = true; // Bad, but only handled by the sniff if Mbstring is available.
 $lÄhtOaika = true; // Bad, handled via transliteration of non-ASCII chars if Mbstring is not available.
+
+/*
+ * Safeguard that the sniff handles PHP 8.4+ asymmetric visibility properties correctly.
+ */
+class Acronym_AsymmetricVisibilityProperties {
+    public private(set) string $valid_name = 'bar'; // Ok.
+    public(set) string $invalidName = 'bar'; // Bad.
+}

WordPress/Tests/NamingConventions/ValidVariableNameUnitTest.php

@@ -98,6 +98,7 @@ final class ValidVariableNameUnitTest extends AbstractSniffUnitTest {
 			227 => 1,
 			238 => function_exists( 'mb_strtolower' ) ? 1 : 0,
 			239 => 1,
+			246 => 1,
 		);
 	}
 

WordPress/Tests/Security/NonceVerificationUnitTest.8.inc

@@ -3,4 +3,5 @@
 class IgnoreProperties {
 	public $_GET = array( 'key' => 'something' ); // OK.
 	public $_POST; // OK.
+	public private(set) string $_REQUEST; // Ok.
 }

WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.1.inc

@@ -311,6 +311,12 @@ list(
 	get($year, $day) => &$not_a_wp_global[$year]
 ] = $array;
 
-// Live coding/parse error.
-// This has to be the last test in the file!
-list( $tab, $tabs
+/*
+ * Safeguard that PHP 8.4+ asymmetric visibility properties don't lead to false positives.
+ * Including those defined using constructor property promotion.
+ */
+class AsymmetricVisibilityProperties {
+    public private(set) string $pagenow = 'bar'; // Ok.
+
+    public function __construct(public protected(set) int $page = 0) {} // Ok.
+}

WordPress/Tests/WP/GlobalVariablesOverrideUnitTest.8.inc

@@ -0,0 +1,8 @@
+<?php
+
+/*
+ * Intentional parse error (missing closing parenthesis).
+ * This should be the only test in this file.
+ */
+
+list( $tab, $tabs