WooCommerce/storefront
2
0
Fork 0
mirror of https://github.com/woocommerce/storefront.git synced 2025-08-18 03:41:10 +08:00
Code Issues Packages Wiki Activity Actions

Ensure that the build has min.js files before generating the .zip file (#2149)

Browse source 
* Ensure that the build has min.js files before generating the .zip file

* improve error message
This commit is contained in:
Luigi Teschio 2024-05-17 11:31:22 +02:00 • committed by GitHub
parent f13b5c2f13
commit 61f976e824
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 43 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
package.json
View file

@ -33,7 +33,7 @@
"scripts": {
"build:dev": "npm run build:js && npm run build:css",
"build": "npm run build:js && npm run build:css && npm run makepot",
"postbuild": "npm run -s archive",
"postbuild": "npm run validate-build && npm run -s archive",
"archive": "rm -rf $npm_package_name && composer archive --file=$npm_package_name --format=zip",
"postarchive": "rm -rf $npm_package_name && unzip $npm_package_name.zip -d $npm_package_name && rm $npm_package_name.zip && zip -r $npm_package_name.zip $npm_package_name && rm -rf $npm_package_name",
"prebuild:js": "rm -f $npm_package_assets_js_min",
@ -58,7 +58,8 @@
"lint:js-fix": "eslint assets/js --ext=js,jsx,ts,tsx --fix",
"lint:php": "composer run-script phpcs ./inc",
"wp-env": "wp-env",
"test:e2e": "npm run wp-env run tests-cli 'wp theme activate storefront' && cross-env wp-scripts test-e2e"
"test:e2e": "npm run wp-env run tests-cli 'wp theme activate storefront' && cross-env wp-scripts test-e2e",
"validate-build": "./validate-build.sh"
},
"jest": {
"preset": "jest-puppeteer",

40
validate-build.sh Executable file
View file

@ -0,0 +1,40 @@
#!/bin/bash
# Initialize the error flag
error_flag=0
# Define the base directory to check
base_dir="./assets"
# Check if the base directory exists
if [ ! -d "$base_dir" ]; then
echo "Error: The directory $base_dir does not exist."
exit 1
fi
# Function to check for corresponding .min.js file
check_for_min_js() {
local js_file="$1"
local min_js_file="${js_file%.js}.min.js"
if [ ! -f "$min_js_file" ]; then
echo "Error: No corresponding .min.js file found for $js_file"
return 1
fi
return 0
}
# Find all .js files within the base directory (excluding .min.js files)
while IFS= read -r -d '' js_file; do
if ! check_for_min_js "$js_file"; then
error_flag=1
fi
done < <(find "$base_dir" -type f -name "*.js" ! -name "*.min.js" -print0)
# Exit with an error code if any .js file is missing its corresponding .min.js file
if [ "$error_flag" -ne 0 ]; then
echo "Error: the ZIP could not be built because minified scripts are missing. Please ensure you are using the correct versions of NPM and Node.js."
exit 1
else
echo "All .js files within $base_dir have corresponding .min.js files."
exit 0
fi