WPSDK/plugin-update-checker
2
0
Fork 0
mirror of https://github.com/YahnisElsts/plugin-update-checker.git synced 2025-10-04 02:02:05 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #419 from marcorocca/master

Browse source 
Fixed a call to non-existent lastRequestApiErrors property
This commit is contained in:
Yahnis Elsts 2021-03-12 13:57:29 +02:00 • committed by GitHub
commit d057b36eb4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Puc/v4p10/Plugin/Ui.php
View file

@ -156,8 +156,9 @@ if ( !class_exists('Puc_v4p10_Plugin_Ui', false) ):
if ( $shouldCheck ) {
$update = $this->updateChecker->checkForUpdates();
$status = ($update === null) ? 'no_update' : 'update_available';
$lastRequestApiErrors = $this->updateChecker->getLastRequestApiErrors();

if ( ($update === null) && !empty($this->lastRequestApiErrors) ) {
if ( ($update === null) && !empty($lastRequestApiErrors) ) {
//Some errors are not critical. For example, if PUC tries to retrieve the readme.txt
//file from GitHub and gets a 404, that's an API error, but it doesn't prevent updates
//from working. Maybe the plugin simply doesn't have a readme.
@ -169,7 +170,7 @@ if ( !class_exists('Puc_v4p10_Plugin_Ui', false) ):
'puc-bitbucket-http-error',
);

foreach ($this->lastRequestApiErrors as $item) {
foreach ($lastRequestApiErrors as $item) {
$wpError = $item['error'];
/** @var WP_Error $wpError */
if ( !in_array($wpError->get_error_code(), $questionableErrorCodes) ) {
@ -180,7 +181,7 @@ if ( !class_exists('Puc_v4p10_Plugin_Ui', false) ):

if ( $foundCriticalErrors ) {
$status = 'error';
set_site_transient($this->manualCheckErrorTransient, $this->lastRequestApiErrors, 60);
set_site_transient($this->manualCheckErrorTransient, $lastRequestApiErrors, 60);
}
}