WPSDK/plugin-update-checker
2
0
Fork 0
mirror of https://github.com/YahnisElsts/plugin-update-checker.git synced 2025-10-04 19:51:11 +08:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactoring: Extract asset detection to a method.

Browse source 
This applies to locally stored plugin icons and banners. The code for icons and banners was very similar, so I've turned it into a utility method to reduce code duplication.
This commit is contained in:
Yahnis Elsts 2021-10-01 14:55:59 +03:00
parent 12cff18273
commit 0e869938e3
1 changed files with 26 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

58
Puc/v4p11/Vcs/PluginUpdateChecker.php
View file

@ -195,27 +195,13 @@ if ( !class_exists('Puc_v4p11_Vcs_PluginUpdateChecker') ):
* @param Puc_v4p11_Plugin_Info $pluginInfo
*/
protected function setIconsFromLocalAssets($pluginInfo) {
$assetDirectory = $this->package->getAbsoluteDirectoryPath() . DIRECTORY_SEPARATOR . 'assets';
if ( !is_dir($assetDirectory) ) {
return;
}
$assetBaseUrl = trailingslashit(plugins_url('', $assetDirectory . '/imaginary.file'));

$filesToKeys = array(
$icons = $this->getLocalAssetUrls(array(
'icon.svg' => 'svg',
'icon-256x256.png' => '2x',
'icon-256x256.jpg' => '2x',
'icon-128x128.png' => '1x',
'icon-128x128.jpg' => '1x',
);

$icons = array();
foreach ($filesToKeys as $fileName => $key) {
$fullIconPath = $assetDirectory . DIRECTORY_SEPARATOR . $fileName;
if ( !isset($icons[$key]) && is_file($fullIconPath) ) {
$icons[$key] = $assetBaseUrl . $fileName;
}
}
));

if ( !empty($icons) ) {
//The "default" key seems to be used only as last-resort fallback in WP core (5.8/5.9),
@ -238,32 +224,40 @@ if ( !class_exists('Puc_v4p11_Vcs_PluginUpdateChecker') ):
* @param Puc_v4p11_Plugin_Info $pluginInfo
*/
protected function setBannersFromLocalAssets($pluginInfo) {
$assetDirectory = $this->package->getAbsoluteDirectoryPath() . DIRECTORY_SEPARATOR . 'assets';
if ( !is_dir($assetDirectory) ) {
return;
}
$assetBaseUrl = trailingslashit(plugins_url('', $assetDirectory . '/imaginary.file'));

$filesToKeys = array(
$banners = $this->getLocalAssetUrls(array(
'banner-772x250.png' => 'high',
'banner-772x250.jpg' => 'high',
'banner-1544x500.png' => 'low',
'banner-1544x500.jpg' => 'low',
);

$banners = array();
foreach ($filesToKeys as $fileName => $key) {
$fullBannerPath = $assetDirectory . DIRECTORY_SEPARATOR . $fileName;
if ( !isset($icons[$key]) && is_file($fullBannerPath) ) {
$banners[$key] = $assetBaseUrl . $fileName;
}
}
));

if ( !empty($banners) ) {
$pluginInfo->banners = $banners;
}
}

/**
* @param array<string, string> $filesToKeys
* @return array<string, string>
*/
protected function getLocalAssetUrls($filesToKeys) {
$assetDirectory = $this->package->getAbsoluteDirectoryPath() . DIRECTORY_SEPARATOR . 'assets';
if ( !is_dir($assetDirectory) ) {
return array();
}
$assetBaseUrl = trailingslashit(plugins_url('', $assetDirectory . '/imaginary.file'));

$foundAssets = array();
foreach ($filesToKeys as $fileName => $key) {
$fullBannerPath = $assetDirectory . DIRECTORY_SEPARATOR . $fileName;
if ( !isset($icons[$key]) && is_file($fullBannerPath) ) {
$foundAssets[$key] = $assetBaseUrl . $fileName;
}
}

return $foundAssets;
}

public function setBranch($branch) {
$this->branch = $branch;
return $this;