From e6b0e00d50081c91161f707ce47869ec5c19443f Mon Sep 17 00:00:00 2001 From: Clemente Raposo Date: Mon, 13 Jan 2025 13:07:20 +0000 Subject: [PATCH] Fix feedback handling after legacy install - Pass back feedback from legacy --- .../Service/Installation/Steps/RunLegacyInstall.php | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/core/backend/Install/Service/Installation/Steps/RunLegacyInstall.php b/core/backend/Install/Service/Installation/Steps/RunLegacyInstall.php index 9a2d122c7..5f08ec5f8 100644 --- a/core/backend/Install/Service/Installation/Steps/RunLegacyInstall.php +++ b/core/backend/Install/Service/Installation/Steps/RunLegacyInstall.php @@ -81,17 +81,11 @@ class RunLegacyInstall implements InstallStepInterface { $result = $this->handler->installLegacy(); - $feedback = new Feedback(); - $feedback->setSuccess(true); - $feedback->setMessages(['Legacy install successful']); - - if ($result === false) { - $feedback->setSuccess(false); - $feedback->setMessages(['Legacy install failed']); - $feedback->setStatusCode(InstallStatus::FAILED); + if ($result->isSuccess() === false) { + $result->setStatusCode(InstallStatus::FAILED); } - return $feedback; + return $result; } }