SuiteCRM/SuiteCRM-Core
2
0
Fork 0
mirror of https://github.com/SuiteCRM/SuiteCRM-Core.git synced 2025-09-02 08:09:19 +08:00
Code Issues Projects Packages Activity Actions

Add error handling to default subpanel statistic

Browse source 
- Check if queries is empty
-- Return error statistic
-- Add logging
This commit is contained in:
Clemente Raposo 2021-03-11 11:15:48 +00:00 • committed by Dillon-Brown
parent 4bda1b7771
commit cc79d2e375
1 changed files with 22 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
core/legacy/Statistics/SubpanelDefault.php
View file

@ -5,13 +5,20 @@ namespace App\Legacy\Statistics;
use App\Entity\Statistic;
use App\Legacy\Data\PresetDataHandlers\SubpanelDataQueryHandler;
use App\Service\StatisticsProviderInterface;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerInterface;
class SubpanelDefault extends SubpanelDataQueryHandler implements StatisticsProviderInterface
class SubpanelDefault extends SubpanelDataQueryHandler implements StatisticsProviderInterface, LoggerAwareInterface
{
use StatisticsHandlingTrait;
public const KEY = 'default';
/**
* @var LoggerInterface
*/
protected $logger;
/**
* @inheritDoc
*/
@ -38,6 +45,12 @@ class SubpanelDefault extends SubpanelDataQueryHandler implements StatisticsProv
$queries = $this->getQueries($module, $id, $subpanel);
if (empty($queries)) {
$this->logger->error('default-statistic: No queries found.', ['query' => $query]);
return $this->getErrorResponse(self::KEY);
}
$parts = $queries[0];
$parts['select'] = 'SELECT COUNT(*) as value';
@ -50,4 +63,12 @@ class SubpanelDefault extends SubpanelDataQueryHandler implements StatisticsProv
return $statistic;
}
/**
* @inheritDoc
*/
public function setLogger(LoggerInterface $logger)
{
$this->logger = $logger;
}
}