Rename default extension to defaultExt

- default is a php reserved word. This was causing issues

.gitignore

@@ -42,9 +42,9 @@ node_modules
 # Custom
 /extensions/
 !extensions/.gitkeep
-!extensions/default/app
-!extensions/default/backend
-!extensions/default/config
+!extensions/defaultExt/app
+!extensions/defaultExt/backend
+!extensions/defaultExt/config
 
 # Tests
 tests/_output/

angular.json

@@ -307,15 +307,15 @@
         }
       }
     },
-    "default": {
+    "defaultExt": {
       "projectType": "application",
       "schematics": {
         "@schematics/angular:component": {
           "style": "scss"
         }
       },
-      "root": "extensions/default",
-      "sourceRoot": "extensions/default/app/src",
+      "root": "extensions/defaultExt",
+      "sourceRoot": "extensions/defaultExt/app/src",
       "prefix": "app",
       "architect": {
         "build": {
@@ -325,27 +325,27 @@
             "commonChunk": false,
             "sourceMap": true,
             "aot": true,
-            "outputPath": "extensions/default/public",
-            "index": "extensions/default/app/src/index.html",
-            "main": "extensions/default/app/src/main.ts",
-            "polyfills": "extensions/default/app/src/polyfills.ts",
-            "tsConfig": "extensions/default/app/tsconfig.app.json",
+            "outputPath": "extensions/defaultExt/public",
+            "index": "extensions/defaultExt/app/src/index.html",
+            "main": "extensions/defaultExt/app/src/main.ts",
+            "polyfills": "extensions/defaultExt/app/src/polyfills.ts",
+            "tsConfig": "extensions/defaultExt/app/tsconfig.app.json",
             "assets": [
-              "extensions/default/app/src/favicon.ico",
-              "extensions/default/app/src/assets"
+              "extensions/defaultExt/app/src/favicon.ico",
+              "extensions/defaultExt/app/src/assets"
             ],
             "styles": [
-              "extensions/default/app/src/styles.scss"
+              "extensions/defaultExt/app/src/styles.scss"
             ],
             "scripts": [],
-            "extraWebpackConfig": "extensions/default/app/webpack.config.js"
+            "extraWebpackConfig": "extensions/defaultExt/app/webpack.config.js"
           },
           "configurations": {
             "production": {
               "fileReplacements": [
                 {
-                  "replace": "extensions/default/app/src/environments/environment.ts",
-                  "with": "extensions/default/app/src/environments/environment.prod.ts"
+                  "replace": "extensions/defaultExt/app/src/environments/environment.ts",
+                  "with": "extensions/defaultExt/app/src/environments/environment.prod.ts"
                 }
               ],
               "optimization": true,
@@ -367,10 +367,10 @@
                   "maximumError": "10kb"
                 }
               ],
-              "extraWebpackConfig": "extensions/default/app/webpack.prod.config.js"
+              "extraWebpackConfig": "extensions/defaultExt/app/webpack.prod.config.js"
             },
             "dev" : {
-              "outputPath": "public/extensions/default"
+              "outputPath": "public/extensions/defaultExt"
             }
           }
         },
@@ -378,13 +378,13 @@
           "builder": "ngx-build-plus:dev-server",
           "options": {
             "browserTarget": "services:build",
-            "extraWebpackConfig": "extensions/default/app/webpack.config.js",
+            "extraWebpackConfig": "extensions/defaultExt/app/webpack.config.js",
             "port": 3000
           },
           "configurations": {
             "production": {
               "browserTarget": "services:build:production",
-              "extraWebpackConfig": "extensions/default/app/webpack.prod.config.js"
+              "extraWebpackConfig": "extensions/defaultExt/app/webpack.prod.config.js"
             }
           }
         },
@@ -397,28 +397,28 @@
         "test": {
           "builder": "ngx-build-plus:karma",
           "options": {
-            "main": "extensions/default/app/src/test.ts",
-            "polyfills": "extensions/default/app/src/polyfills.ts",
-            "tsConfig": "extensions/default/app/tsconfig.spec.json",
-            "karmaConfig": "extensions/default/app/karma.conf.js",
+            "main": "extensions/defaultExt/app/src/test.ts",
+            "polyfills": "extensions/defaultExt/app/src/polyfills.ts",
+            "tsConfig": "extensions/defaultExt/app/tsconfig.spec.json",
+            "karmaConfig": "extensions/defaultExt/app/karma.conf.js",
             "assets": [
-              "extensions/default/app/src/favicon.ico",
-              "extensions/default/app/src/assets"
+              "extensions/defaultExt/app/src/favicon.ico",
+              "extensions/defaultExt/app/src/assets"
             ],
             "styles": [
-              "extensions/default/app/src/styles.scss"
+              "extensions/defaultExt/app/src/styles.scss"
             ],
             "scripts": [],
-            "extraWebpackConfig": "extensions/default/app/webpack.config.js"
+            "extraWebpackConfig": "extensions/defaultExt/app/webpack.config.js"
           }
         },
         "lint": {
           "builder": "@angular-devkit/build-angular:tslint",
           "options": {
             "tsConfig": [
-              "extensions/default/app/tsconfig.app.json",
-              "extensions/default/app/tsconfig.spec.json",
-              "extensions/default/app/e2e/tsconfig.json"
+              "extensions/defaultExt/app/tsconfig.app.json",
+              "extensions/defaultExt/app/tsconfig.spec.json",
+              "extensions/defaultExt/app/e2e/tsconfig.json"
             ],
             "exclude": [
               "**/node_modules/**"
@@ -428,7 +428,7 @@
         "e2e": {
           "builder": "@angular-devkit/build-angular:protractor",
           "options": {
-            "protractorConfig": "extensions/default/app/e2e/protractor.conf.js",
+            "protractorConfig": "extensions/defaultExt/app/e2e/protractor.conf.js",
             "devServerTarget": "services:serve"
           },
           "configurations": {

extensions/defaultExt/app/src/index.html

@@ -5,7 +5,7 @@
   <title>Default Extension</title>
   <base href="/">
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <link rel="icon" type="image/x-icon" href="extensions/default/app/src/favicon.ico">
+  <link rel="icon" type="image/x-icon" href="extensions/defaultExt/app/src/favicon.ico">
 </head>
 <body>
   <app-root></app-root>

extensions/defaultExt/app/webpack.config.js

@@ -3,7 +3,7 @@ const ModuleFederationPlugin = require('webpack/lib/container/ModuleFederationPl
 module.exports = {
   output: {
     publicPath: 'auto',
-    uniqueName: 'default'
+    uniqueName: 'defaultExt'
   },
   optimization: {
     runtimeChunk: false
@@ -11,14 +11,14 @@ module.exports = {
   plugins: [
     new ModuleFederationPlugin({
 
-      name: 'default',
+      name: 'defaultExt',
       filename: 'remoteEntry.js',
       library: {
         type: 'window',
-        name: 'default',
+        name: 'defaultExt',
       },
       exposes: {
-        './Module': './extensions/default/app/src/extension.module.ts'
+        './Module': './extensions/defaultExt/app/src/extension.module.ts'
       },
 
       shared: {

extensions/defaultExt/config/extension.php

@@ -9,11 +9,11 @@ if (!isset($container)) {
 /** @var Container $container */
 $extensions = $container->getParameter('extensions') ?? [];
 
-$extensions['default'] = [
-    'remoteEntry' => './extensions/default/remoteEntry.js',
-    'remoteName' => 'default',
+$extensions['defaultExt'] = [
+    'remoteEntry' => './extensions/defaultExt/remoteEntry.js',
+    'remoteName' => 'defaultExt',
     'enabled' => false,
-    'extension_name' => 'Default',
+    'extension_name' => 'Default Extension',
     'extension_uri' =>  'https://suitecrm.com',
     'description' => 'An example Extension template or for simple instance customisations',
     'version' =>  '1.0.0',

package.json

@@ -11,12 +11,12 @@
     "build-dev:shell": "ng build shell",
     "build-dev:common": "ng build common",
     "build-dev:core": "ng build core",
-    "build-dev:default": "ng build default --configuration dev",
+    "build-dev:defaultExt": "ng build defaultExt --configuration dev",
     "build": "npm run build:shell",
     "build:shell": "ng build shell --configuration production",
     "build:common": "ng build common --configuration production",
     "build:core": "ng build core --configuration production",
-    "build:default": "ng build default --configuration production",
+    "build:defaultExt": "ng build defaultExt --configuration production",
     "test": "npm run test:shell",
     "test:core": "ng test core",
     "gen-index": "barrelsby --delete -e '.*\\.spec.*' -q",