SuiteCRM/SuiteCRM-Core
2
0
Fork 0
mirror of https://github.com/SuiteCRM/SuiteCRM-Core.git synced 2025-09-02 08:09:19 +08:00
Code Issues Projects Packages Activity Actions

Fix #504 - Update required validator to not validate line-items

Browse source
This commit is contained in:
Clemente Raposo 2024-07-29 14:40:19 +01:00 • committed by c.raposo
parent f4060d6fb3
commit 493952fd18
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
core/app/core/src/lib/services/record/validation/validators/required.validator.ts
View file

@ -27,9 +27,7 @@
import {Injectable} from '@angular/core';
import {ValidatorInterface} from '../validator.Interface';
import {AbstractControl} from '@angular/forms';
import {isTrue, Record} from 'common';
import {ViewFieldDefinition} from 'common';
import {StandardValidationErrors, StandardValidatorFn} from 'common';
import {isTrue, Record, StandardValidationErrors, StandardValidatorFn, ViewFieldDefinition} from 'common';
import {FormControlUtils} from '../../field/form-control.utils';
export const requiredValidator = (utils: FormControlUtils): StandardValidatorFn => (
@ -87,12 +85,21 @@ export class RequiredValidator implements ValidatorInterface {
return false;
}
const viewFieldType = viewField?.type ?? null;
const fieldDefinitionType = viewField?.fieldDefinition?.type ?? null;
if (viewFieldType === 'line-items' || fieldDefinitionType === 'line-items') {
return false;
}
return isTrue(viewField.fieldDefinition.required);
}
getValidator(viewField: ViewFieldDefinition): StandardValidatorFn[] {
getValidator(viewField: ViewFieldDefinition, record: Record): StandardValidatorFn[] {
if(viewField.type === 'boolean'){
const type = viewField?.type ?? viewField?.fieldDefinition?.type ?? '';
if (type === 'boolean') {
return [booleanRequiredValidator(this.utils)];
}