chore: lint, updated commitlint config

This commit is contained in:
Julian Lam 2020-11-10 11:24:36 -05:00
parent faae9640d8
commit 0d4598efb9
2 changed files with 32 additions and 10 deletions

View file

@ -1,3 +1,26 @@
'use strict'; 'use strict';


module.exports = { extends: ['@commitlint/config-angular'] }; module.exports = {
extends: ['@commitlint/config-angular'],
rules: {
'header-max-length': [1, 'always', 72],
'type-enum': [
2,
'always',
[
'breaking',
'build',
'chore',
'ci',
'docs',
'feat',
'fix',
'perf',
'refactor',
'revert',
'style',
'test',
],
],
},
};

View file

@ -1,5 +1,4 @@
'use strict'; 'use strict';
/* global module, require */


var apiMiddleware = require('./middleware'); var apiMiddleware = require('./middleware');
var errorHandler = require('../../lib/errorHandler'); var errorHandler = require('../../lib/errorHandler');
@ -8,12 +7,12 @@ var multipart = require.main.require('connect-multiparty');
var uploadController = require.main.require('./src/controllers/uploads'); var uploadController = require.main.require('./src/controllers/uploads');
var meta = require.main.require('./src/meta'); var meta = require.main.require('./src/meta');


module.exports = function(/*middleware*/) { module.exports = function (/* middleware */) {
var app = require('express').Router(); var app = require('express').Router();


app.route('/upload').post(apiMiddleware.requireUser, multipart(), function(req, res, next) { app.route('/upload').post(apiMiddleware.requireUser, multipart(), function (req, res, next) {
uploadController.upload(req, res, function(uploadedFile, callback) { uploadController.upload(req, res, function (uploadedFile, callback) {
if (parseInt(meta.config.allowFileUploads) !== 1) { if (parseInt(meta.config.allowFileUploads, 10) !== 1) {
return callback(new Error('[[error:uploads-are-disabled]]')); return callback(new Error('[[error:uploads-are-disabled]]'));
} }


@ -22,15 +21,15 @@ module.exports = function(/*middleware*/) {
}); });


app.route('/maintenance') app.route('/maintenance')
.post(apiMiddleware.requireUser, apiMiddleware.requireAdmin, function (req, res, next) { .post(apiMiddleware.requireUser, apiMiddleware.requireAdmin, function (req, res) {
meta.configs.set('maintenanceMode', 1, function (err) { meta.configs.set('maintenanceMode', 1, function (err) {
return errorHandler.handle(err, res); return errorHandler.handle(err, res);
}) });
}) })
.delete(apiMiddleware.requireUser, apiMiddleware.requireAdmin, function (req, res, next) { .delete(apiMiddleware.requireUser, apiMiddleware.requireAdmin, function (req, res) {
meta.configs.set('maintenanceMode', 0, function (err) { meta.configs.set('maintenanceMode', 0, function (err) {
return errorHandler.handle(err, res); return errorHandler.handle(err, res);
}) });
}); });


return app; return app;