mirror of
https://github.com/discourse/discourse.git
synced 2026-08-04 10:39:43 +08:00
d2d79d290eThis creates an explicit "default homepage" setting, because right now
the experience of changing the homepage via the "top menu" setting isn't
very intuitive. This will also make it easier to support new homepage
options in the future that don't necessarily need to exist within "top
menu."
The setting is empty by default, and when empty it falls back to "First
item in top menu" — using the current functionality as a fallback means
we don't need a migration.
The options in the list are the core top menu choices plus anything
registered via `Discourse.filters.push(:filter)`. Registered filters are
an existing pattern that come with all the prerequisites to function as
a homepage (server & client routes, and a topic list).
So for example, how the "votes" option is produced
plugins/discourse-topic-voting/plugin.rb
```ruby
Discourse.filters.push(:votes)
Discourse.anonymous_filters.push(:votes)
```
anonymous_filters is optional, if there's no anonymous equivalent of a
given option, we fall back to the first anon-viewable top menu item
(there's always at least one)
lib/discourse_topic_voting/topic_query_extension.rb
```ruby
def list_votes
create_list(:votes, unordered: true) do |topics|
topics.joins(
"LEFT JOIN topic_voting_topic_vote_count dvtvc ON dvtvc.topic_id = topics.id",
).order("COALESCE(dvtvc.votes_count,'0')::integer DESC, topics.bumped_at DESC")
end
end
```
config/locales/client.en.yml
```yaml
js:
filters:
votes:
title: "Votes"
help: "topics with the all time most votes"
```
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/6b580e92-1b58-477c-81ab-6ceacc020672"
/>
This also adds a persistent "Default" option to the Default Home Page
user preference, which was previously only visible when a custom
homepage is set by a theme.
A future enhancement could add a plugin API for registering non-filter
homepage options (e.g. a chat channel)
Some related fixes along for the ride:
* select-kit treated a blank value as "clear selection", so it could not
be selected or displayed... this allows "First item in top menu" as an
alias for being unset
* the admin combo-box couldn't detect when the first choice's value was
blank, and submitted the whole object
* topic lists advertised RSS feeds that don't exist for registered
filters (this was happening with /votes)
23 lines
660 B
Ruby
Vendored
23 lines
660 B
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
module TopMenu
|
|
def self.choices
|
|
base = %w[latest new unseen top categories read posted bookmarks hot]
|
|
begin
|
|
base << "unread" unless UpcomingChanges.enabled?(:enable_unified_new)
|
|
rescue ArgumentError
|
|
# During initial settings load, the enable_unified_new setting may not
|
|
# be registered yet. Default to including unread in that case.
|
|
base << "unread"
|
|
end
|
|
base
|
|
end
|
|
|
|
def self.crawler_homepage_choices
|
|
choices & (Discourse.anonymous_filters.map(&:to_s) + %w[new categories])
|
|
end
|
|
|
|
def self.homepage_choices
|
|
choices | (Discourse.filters.map(&:to_s) - %w[unread])
|
|
end
|
|
end
|
