0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-06 13:08:40 +08:00
discourse/lib/stylesheet/watcher.rb
David Taylor 0a35a36dc7
DEV: Refresh all plugin stylesheet targets on change (#40448)
We were previously looking for path segments like `/admin/` and
`/mobile/` to deduce the 'target' of plugin CSS files. In reality, the
file path provides no guarantee about the configured target.

The easy fix is to rebuild all known targets whenever any plugin css
changes. In general, plugins only have one or two targets, and only have
a small number of css files, so this shouldn't be a perf concern.
2026-06-01 18:11:39 +01:00

138 lines
4.1 KiB
Ruby
Vendored
Raw Permalink Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

# frozen_string_literal: true
require "listen"
module Stylesheet
class Watcher
def self.watch(paths = nil)
watcher = new(paths)
watcher.start
watcher
end
def initialize(paths)
@paths = paths || Watcher.default_paths
@queue = Queue.new
end
def self.default_paths
return @default_paths if @default_paths
@default_paths = ["app/assets/stylesheets"]
Discourse.plugins.each do |plugin|
if plugin.path.to_s.include?(Rails.root.to_s)
path = File.dirname(plugin.path).sub(Rails.root.to_s, "").sub(%r{\A/}, "")
path << "/assets/stylesheets"
@default_paths << path if File.exist?(path)
else
# if plugin doesnt seem to be in our app, consider it as outside of the app
# and ignore it
warn("[stylesheet watcher] Ignoring outside of rails root plugin: #{plugin.path}")
end
end
@default_paths
end
def start
Thread.new do
worker_loop while true
rescue => e
STDERR.puts "CSS change notifier crashed \n#{e}"
start
end
listener_opts = { ignore: [/node_modules/], only: /\.s?css\z/ }
listener_opts[:force_polling] = true if ENV["FORCE_POLLING"]
Thread.new do
begin
plugins_paths =
Dir
.glob("#{Rails.root.join("plugins/*")}")
.map do |file|
if File.symlink?(file)
File.expand_path(File.readlink(file), "#{Rails.root.join("plugins")}")
else
file
end
end
.compact
listener =
Listen.to(*@paths, listener_opts) do |modified, added, _|
paths = [modified, added].flatten
paths.compact!
paths.map! do |long|
plugin_name = nil
plugins_paths.each do |plugin_path|
if long.include?("#{plugin_path}/")
plugin_name = File.basename(plugin_path)
break
end
end
target = nil
target_match =
long.match(/admin|desktop|mobile|publish|wizard|wcag|color_definitions/)
target = target_match[0] if target_match&.length
{ basename: File.basename(long), target: target, plugin_name: plugin_name }
end
process_change(paths)
end
rescue => e
STDERR.puts "Failed to listen for CSS changes: \n#{e}"
end
listener.start
sleep
end
end
def core_assets_refresh(target)
if target&.match(/wcag|color_definitions/)
Stylesheet::Manager.clear_color_scheme_cache!
return
end
targets = target ? [target] : %w[admin common desktop mobile]
Stylesheet::Manager.clear_core_cache!(targets)
message =
targets.map! { |name| Stylesheet::Manager.new.stylesheet_data(name.to_sym) }.flatten!
MessageBus.publish "/file-change", message
end
def plugin_assets_refresh(plugin_name)
Stylesheet::Manager.clear_plugin_cache!(plugin_name)
# A changed file can't be mapped back to a single target (it may be a
# shared partial), so refresh every target the plugin defines.
targets = []
targets << plugin_name if DiscoursePluginRegistry.stylesheets_exists?(plugin_name)
DiscoursePluginRegistry::STYLESHEET_TARGETS.each do |target|
if DiscoursePluginRegistry.stylesheets_exists?(plugin_name, target)
targets << "#{plugin_name}_#{target}"
end
end
message = targets.flat_map { |name| Stylesheet::Manager.new.stylesheet_data(name.to_sym) }
MessageBus.publish "/file-change", message if message.present?
end
def worker_loop
path = @queue.pop
@queue.pop while @queue.length > 0
if path[:plugin_name]
plugin_assets_refresh(path[:plugin_name])
else
core_assets_refresh(path[:target])
end
end
def process_change(paths)
paths.each { |path| @queue.push path }
end
end
end