Exact

Exact Union RegExp

Alan Guo Xiang Tan 5807c42688 SECURITY: Authorize secure-upload hotlink downloads against post user [backport 2026.4] ... Backport of #705 to release/2026.4. --- Advisory: https://github.com/discourse/discourse/security/advisories/GHSA-3876-w96v-8v38 When a post embeds an `<img>` pointing at a secure-uploads URL whose upload is owned by an access-controlled post (for example a private category), `Jobs::PullHotlinkedImages` would resolve the presigned S3 URL and attach a fresh local copy of the upload to the embedding post regardless of whether its author could see the original. A user could hotlink the secure-uploads URL of media they should not have access to into a post they authored, and `Jobs::PullHotlinkedImages` would create a fresh local copy attached to their post. This commit gates `Jobs::PullHotlinkedImages#should_download_image?` on a new `can_see_upload?` helper. For secure uploads the helper checks the post author against the upload's `access_control_post` with `user.guardian.can_see_post?`. When the author cannot see the access-control post, the job leaves the original secure URL in place and does not create a local copy.		2026-06-30 16:16:31 +02:00
..
regular	DEV: Remove IMAP support in Discourse (#37002)	2026-01-12 10:07:26 +10:00
scheduled	FEATURE: Add problem checks page to admin panel and allow ignoring problem checks (#39103)	2026-04-23 08:28:33 +08:00
about_stats_spec.rb
activation_reminder_emails_spec.rb
auto_queue_handler_spec.rb
automatic_group_membership_spec.rb
backfill_sidebar_site_settings_spec.rb
bookmark_reminder_notifications_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
bulk_grant_trust_level_spec.rb	PERF: Add Users to Group Pt. 1 (#38737)	2026-03-26 09:11:22 -05:00
bulk_invite_spec.rb	DEV: Update bulk-invite logs and PM template (#27057)	2024-05-17 12:21:21 -06:00
bump_topic_spec.rb
call_discourse_hub_spec.rb	FIX: Handle boolean values in version check response (#38786)	2026-03-23 15:39:38 +00:00
change_display_name_spec.rb	FIX: Preserve display name in quotes when using the rich text editor (#38078)	2026-02-26 21:04:07 +01:00
check_new_features_spec.rb	FIX: Limit what's new to the last 4 months (#39216)	2026-04-15 11:43:12 +10:00
check_translation_overrides_spec.rb	DEV: Refresh translation override status when updating (#31233)	2025-02-07 14:12:28 +08:00
clean_dismissed_topic_users_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
clean_up_associated_accounts_spec.rb
clean_up_crawler_stats_spec.rb
clean_up_email_change_requests_spec.rb
clean_up_email_logs_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
clean_up_inactive_users_spec.rb
clean_up_post_reply_keys_spec.rb
clean_up_tags_spec.rb	DEV: fix a large amount of typos (#37428)	2026-02-02 16:31:58 +11:00
clean_up_unused_staged_users_spec.rb
clean_up_unused_user_api_key_clients_spec.rb	Require permitted scopes when registering a client (#29718)	2024-11-19 15:28:04 -05:00
clean_up_unused_user_api_keys_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
clean_up_uploads_spec.rb	FIX: twitter_summary_large_image is renamed to x (#31870)	2025-03-19 11:55:11 +11:00
clean_up_user_api_keys_max_life_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
clean_up_user_export_topics_spec.rb
cleanup_problem_check_trackers_spec.rb	DEV: Clean up trackers with outdated targets (#35978)	2026-01-14 12:54:16 +01:00
cleanup_redelivering_web_hook_events_spec.rb	FEATURE: Add Mechanism to redeliver all failed webhook events (#27609)	2024-07-08 15:43:16 -05:00
close_topic_spec.rb	DEV: rename topic_id to timerable_id for BaseTimer (#34667)	2025-09-17 13:19:17 +08:00
correct_missing_dualstack_urls_spec.rb
crawl_topic_link_spec.rb	DEV: Clean up scope resolution operators in plugins (#34979)	2025-09-30 14:36:34 +02:00
create_linked_topic_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
create_missing_avatars_spec.rb
create_recent_post_search_indexes_spec.rb
create_user_reviewable_spec.rb
delete_replies_spec.rb	FIX: DeleteReplies should use the guardian instead of checking for staff (#35443)	2025-10-16 18:26:41 +02:00
delete_topic_spec.rb
delete_user_posts_spec.rb	FIX: return nil correctly for nil check (#37460)	2026-02-02 15:43:56 -08:00
deliver_push_notification_spec.rb	DEV: Centralize push notification delivery into a single job (#39207)	2026-04-14 11:55:45 -03:00
download_avatar_from_url_spec.rb
download_backup_email_spec.rb	FEATURE: better email subject lines (#36040)	2026-04-24 15:14:10 +04:00
download_profile_background_from_url_spec.rb
emit_web_hook_event_spec.rb	DEV: always load the excon gem	2026-01-15 17:13:11 -05:00
enqueue_digest_emails_spec.rb	FIX: send activity summaries based on "last seen" (#27035)	2024-05-22 10:23:03 +02:00
enqueue_suspect_users_spec.rb	FIX: Exclude suspended users from suspect users review queue (#37796)	2026-02-16 10:46:52 +08:00
ensure_db_consistency_spec.rb	FIX: we introduced a Jobs::UserEmail which broke consistency checks (#30409)	2024-12-22 21:33:47 +11:00
ensure_s3_uploads_existence_multisite_spec.rb	FIX: Jobs::EnsureS3UploadsExistence broken for multisite (#27401)	2024-06-10 16:26:39 +08:00
ensure_s3_uploads_existence_spec.rb	DEV: Deprecate the assignment of nil to site settings (#36093)	2025-12-01 15:04:23 +08:00
export_csv_file_spec.rb	FIX: align staff action CSV export with log visibility rules [backport 2026.4] (#40192)	2026-05-20 10:35:23 -03:00
export_user_archive_spec.rb	FIX: Escape markdown characters in upload filenames (#39133)	2026-04-14 10:37:41 +02:00
feature_topic_users_spec.rb
fix_out_of_sync_user_uploaded_avatar_spec.rb
fix_primary_emails_for_staged_users_spec.rb
fix_s3_etags_spec.rb
fix_user_usernames_and_groups_names_clash_spec.rb
grant_anniversary_badges_spec.rb
grant_new_user_of_the_month_badges_spec.rb
ignored_users_summary_spec.rb
index_user_fields_for_search_spec.rb	FIX: Move user reindexing into a job (#26753)	2024-04-25 20:58:34 +08:00
invalidate_inactive_admins_spec.rb
invite_email_spec.rb	DEV: Tighten protections when disabling allow_email_invites (#37453)	2026-02-02 11:40:04 -05:00
jobs_base_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
jobs_scheduled_spec.rb	DEV: Support a perform_when_readonly option for Jobs::Scheduled (#30478)	2024-12-27 09:42:40 +08:00
jobs_spec.rb	FIX: Redo Sidekiq monitoring to restart stuck sidekiq processes (#30198)	2024-12-18 12:48:50 +08:00
mass_award_badge_spec.rb
notify_category_change_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
notify_mailing_list_subscribers_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
notify_moved_posts_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
notify_reviewable_spec.rb	FEATURE: Support designating multiple groups as mods on category (#28655)	2024-09-04 04:38:46 +03:00
notify_tag_change_spec.rb	FIX: Allow "watching first post" notification to fire when tags edit notifications are disabled (#37935)	2026-02-20 16:59:53 +08:00
old_keys_reminder_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
open_topic_spec.rb	DEV: rename topic_id to timerable_id for BaseTimer (#34667)	2025-09-17 13:19:17 +08:00
pending_queued_posts_reminder_spec.rb
pending_reviewables_reminder_spec.rb
pending_users_reminder_spec.rb
periodical_updates_spec.rb	DEV: ensure rebaking works even when some users have inconsistent data (#30261)	2024-12-16 19:48:25 +08:00
poll_mailbox_spec.rb	DEV: Database backed admin notices (#26192)	2024-05-23 09:29:08 +08:00
post_update_topic_tracking_state_spec.rb	FIX: PM unread count shows (1) but message list is empty (#38733)	2026-03-20 09:50:38 +01:00
post_uploads_recovery_spec.rb
process_bulk_invite_emails_spec.rb
process_email_spec.rb
process_localized_cooked_spec.rb	FIX: Update topic excerpts when the first post is localized (#36885)	2025-12-29 23:33:39 +08:00
process_post_spec.rb	DEV: Clean up scope resolution operators in plugins (#34979)	2025-09-30 14:36:34 +02:00
process_shelved_notifications_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
publish_topic_to_category_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
pull_hotlinked_images_spec.rb	SECURITY: Authorize secure-upload hotlink downloads against post user [backport 2026.4]	2026-06-30 16:16:31 +02:00
pull_user_profile_hotlinked_images_spec.rb
purge_expired_ignored_users_spec.rb
push_notification_spec.rb	DEV: Centralize push notification delivery into a single job (#39207)	2026-04-14 11:55:45 -03:00
rebake_custom_emoji_posts_spec.rb
redeliver_web_hook_events_spec.rb	FIX: Match webhook-related messagebus audience to controller audience [backport 2026.4] (#40696)	2026-06-09 18:22:14 +01:00
refresh_users_reviewable_counts_spec.rb	FEATURE: Support designating multiple groups as mods on category (#28655)	2024-09-04 04:38:46 +03:00
reindex_search_spec.rb	FEATURE: Add full-text search for chat messages (#34704)	2025-10-22 11:30:35 +02:00
remove_banner_spec.rb
reviewable_priorities_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
run_problem_check_spec.rb	FIX: Fix scheduled targeted problem checks (#35696)	2025-11-10 10:09:14 +08:00
run_problem_checks_spec.rb	FIX: Fix scheduled targeted problem checks (#35696)	2025-11-10 10:09:14 +08:00
send_push_notification_spec.rb	DEV: Centralize push notification delivery into a single job (#39207)	2026-04-14 11:55:45 -03:00
send_system_message_spec.rb
suspicious_login_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00
sync_access_control_for_uploads_spec.rb	DEV: Add setting to tag s3 objects enabling tag based access control policies (#32988)	2025-06-16 13:26:18 +08:00
sync_topic_user_bookmarked_spec.rb
tl3_promotions_spec.rb	DEV: Add tl3_custom_promotions plugin modifier to tl3_promotions.rb (#29834)	2024-11-22 15:28:43 -05:00
toggle_topic_closed_spec.rb	DEV: rename topic_id to timerable_id for BaseTimer (#34667)	2025-09-17 13:19:17 +08:00
topic_timer_enqueuer_spec.rb	DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)	2025-10-06 16:11:01 +02:00
truncate_user_flag_stats_spec.rb
unsilence_users_spec.rb
update_animated_uploads_spec.rb
update_gravatar_spec.rb
update_topic_hot_scores_spec.rb	DEV: Clean up scope resolution operators in plugins (#34979)	2025-09-30 14:36:34 +02:00
update_username_spec.rb
user_email_spec.rb	DEV: add shortcut fab!(:variable, :fabricator) to specs (#33577)	2025-07-11 11:16:34 -03:00