mirror of
https://github.com/discourse/discourse.git
synced 2026-08-09 21:45:25 +08:00
96c4e8d994When `disable_tags_edit_notifications` support was added to `NotifyTagChange`, the entire job was gated with an early return: ``` return if SiteSetting.disable_tags_edit_notifications && !args[:force] ``` This blocks all notifications from the job including `notify_first_post_watchers` (the bug), which is semantically different from a “tag edit” notification. The setting was meant to suppress “the tags on this topic changed” notifications (`notify_post_users`), but inadvertently also suppressed “a topic now matches your watched tag” notifications (`notify_first_post_watchers`). The `PostRevisor` also gates the job enqueue: ``` if !SiteSetting.disable_tags_edit_notifications Jobs.enqueue(:notify_tag_change, ...) end ``` So when `disable_tags_edit_notifications = true`, the `NotifyTagChange` job is never even enqueued, and WFP notifications are completely silenced for tag additions. This PR fixes the issue. |
||
|---|---|---|
| .. | ||
| concerns | ||
| onceoff | ||
| regular | ||
| scheduled | ||
| base.rb | ||
