Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-08 17:53:55 +08:00
Code Packages Activity Actions
discourse/spec/fixtures
History
Exact
Gabriel Grubba 6800d63bfc
 FIX: type object setting not redirecting on saving (#36150) 
With https://github.com/discourse/discourse/pull/35349, now site
settings do not return a body on update, which broke the type object
setting editor's save flow. This commit adds handling for that case.

And also adds testing to ensure that after saving the setting, we are
redirected to another page.

Renamed `admin_objects_theme_setting_editor` to
`admin_objects_setting_editor` since it can be used for both themes and
settings.


Before:


https://github.com/user-attachments/assets/5e019428-e126-4084-80a6-eb324c851427


Now:


https://github.com/user-attachments/assets/9ac59ca2-1896-490a-866c-630a5a201471

A future todo would be to migrate [ThemeController#update_single_setting
](71834c898f/app/controllers/admin/themes_controller.rb (L343-L365))
to use the same pattern as
[`SiteSettingController#update`](d8e7741d96/app/controllers/admin/site_settings_controller.rb (L25-L53))
2025-11-21 10:26:08 -03:00
..
backups
csv FIX: S3Inventory#backfill_etags_and_list_missing need to unescape key (#30787) 2025-01-15 14:52:49 +08:00
db FIX: Remove unsupported SQL from DB dump during restore 2025-11-03 11:15:00 +01:00
emails FIX: correctly extract body and/or reply from exchange emails (#30512) 2024-12-31 15:29:36 +01:00
encodings
feed FIX: Select best link from Atom feed (#15663) 2022-01-21 17:54:18 +02:00
i18n FIX: Missing translation when translation override contained a %{key} (#16625) 2022-05-04 17:35:22 +02:00
images FEATURE: Upcoming changes part 1 (#34617) 2025-10-30 10:46:14 +10:00
json DEV: Fix flaky core backend spec (#22650) 2023-07-18 07:01:19 +08:00
md A11Y: Set role=presentation if alt attr is missing (#18546) 2022-10-12 14:07:37 +03:00
media DEV: uses local playwright chromium for now (#32613) 2025-05-07 10:17:25 +02:00
mmdb DEV: Revert rails 7.1 upgrade (#27522) 2024-06-18 23:48:30 +02:00
multisite
onebox FIX: correctly unescape title for amazon oneboxes (#33010) 2025-06-02 17:50:13 +05:30
pdf
plugins PERF: Compile main locale bundles just-in-time (#32335) 2025-04-28 10:31:27 +01:00
scss
site_settings FIX: type object setting not redirecting on saving (#36150) 2025-11-21 10:26:08 -03:00
svg FIX: Allow attachments to be opened in a new tab instead of downloading them (#30535) 2025-01-07 10:32:32 +08:00
theme_locales/objects_settings DEV: Support translations for property labels in objects schema editor (#26362) 2024-03-28 10:53:51 +08:00
theme_settings DEV: Change category type to categories type for theme object schema (#26339) 2024-03-27 10:54:30 +08:00
themes DEV: Add skip_migrations param when importing remote theme (#25218) 2024-01-11 14:04:02 +08:00
woff2