2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-09-06 10:50:21 +08:00
discourse/spec/requests/safe_mode_controller_spec.rb
Alan Guo Xiang Tan 8e3691d537 PERF: Eager load Theme associations in Stylesheet Manager.
Before this change, calling `StyleSheet::Manager.stylesheet_details`
for the first time resulted in multiple queries to the database. This is
because the code was modelled in a way where each `Theme` was loaded
from the database one at a time.

This PR restructures the code such that it allows us to load all the
theme records in a single query. It also allows us to eager load the
required associations upfront. In order to achieve this, I removed the
support of loading multiple themes per request. It was initially added
to support user selectable theme components but the feature was never
completed and abandoned because it wasn't a feature that we thought was
worth building.
2021-06-21 11:06:58 +08:00

44 lines
1.1 KiB
Ruby

# frozen_string_literal: true
require 'rails_helper'
RSpec.describe SafeModeController do
describe 'index' do
it 'never includes customizations' do
theme = Fabricate(:theme)
theme.set_field(target: :common, name: "header", value: "My Custom Header")
theme.save!
theme.set_default!
get '/safe-mode'
expect(response.status).to eq(200)
expect(response.body).not_to include("My Custom Header")
end
end
describe 'enter' do
context 'when no params are given' do
it 'should redirect back to safe mode page' do
post '/safe-mode'
expect(response.status).to redirect_to(safe_mode_path)
end
end
context 'when safe mode is not enabled' do
it 'should raise an error' do
SiteSetting.enable_safe_mode = false
post '/safe-mode'
expect(response.status).to eq(404)
end
it "doesn't raise an error for staff" do
SiteSetting.enable_safe_mode = false
sign_in(Fabricate(:moderator))
post '/safe-mode'
expect(response.status).to redirect_to(safe_mode_path)
end
end
end
end