2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-10-04 17:32:34 +08:00
discourse/app
David Taylor 89df65e843
FIX: Avoid possible rendering infinite-loop in post-menu (#30873)
ff815384 introduced a modifier which changes tracked state. If the
conditions are correct, this can cause an infinite re-rendering loop.
One example is [here](https://meta.discourse.org/t/346215/4), although
there are other non-dev-tools things which could trigger this kind of
loop. As a general rule, modifiers should not change tracked state.

This commit changes the approach to match the rest of the new-post-menu
assumptions: instead of trying to modify `collapsed` at runtime, the
rendering of individual buttons has the `>1` logic. That matches the
existing logic
[here](89ff7d51e6/app/assets/javascripts/discourse/app/components/post/menu.gjs (L392C18-L394C6)).
2025-01-20 15:16:53 +00:00
..
assets FIX: Avoid possible rendering infinite-loop in post-menu (#30873) 2025-01-20 15:16:53 +00:00
controllers FIX: Remove /u/ from robots (#30782) 2025-01-15 13:42:08 +08:00
helpers DEV: Remove more ember options (#30852) 2025-01-18 15:58:19 +01:00
jobs FIX: Add Type column to Flag Status CSV export (#30756) 2025-01-14 13:31:55 +10:00
mailers UX: Use a dropdown for SSL mode for group SMTP (#27932) 2024-07-18 10:33:14 +10:00
models FIX: Don't allow editing own posts user can no longer see (#30839) 2025-01-20 10:09:58 +08:00
serializers FIX: ensure GroupChooser works with localized group names (#30593) 2025-01-13 11:29:04 +01:00
services DEV: Add problem check informing about admin layout deprecation (#30685) 2025-01-14 13:22:59 +08:00
views DEV: Add a nofollow to /u so user profiles don't get added as a target for crawling (#30693) 2025-01-13 13:50:00 +08:00