mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-25 18:28:31 +08:00
Edge case where in an outlier case moderators can see ip addresses and should not be allowed to
118 lines
3.4 KiB
Ruby
Vendored
118 lines
3.4 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Admin::ScreenedEmailsController do
|
|
fab!(:admin)
|
|
fab!(:moderator)
|
|
fab!(:user)
|
|
fab!(:screened_email)
|
|
|
|
describe "#index" do
|
|
shared_examples "screened emails accessible" do
|
|
it "returns screened emails" do
|
|
get "/admin/logs/screened_emails.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
json = response.parsed_body
|
|
expect(json.size).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "when logged in as an admin" do
|
|
before { sign_in(admin) }
|
|
|
|
include_examples "screened emails accessible"
|
|
end
|
|
|
|
context "when logged in as a moderator and has permission to view emails" do
|
|
before do
|
|
sign_in(moderator)
|
|
SiteSetting.moderators_view_emails = true
|
|
end
|
|
|
|
include_examples "screened emails accessible"
|
|
|
|
it "does not include IP addresses without permission to view IPs" do
|
|
Fabricate(:screened_email, email: "test@example.com")
|
|
SiteSetting.moderators_view_ips = false
|
|
|
|
get "/admin/logs/screened_emails.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
email = response.parsed_body.find { |e| e["email"] == "test@example.com" }
|
|
expect(email).to be_present
|
|
expect(email).not_to have_key("ip_address")
|
|
end
|
|
end
|
|
|
|
context "when logged in as a non-staff user" do
|
|
before { sign_in(user) }
|
|
|
|
it "denies access with a 404 response" do
|
|
get "/admin/logs/screened_emails.json"
|
|
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
|
|
end
|
|
end
|
|
|
|
context "when logged in as a moderator but no permission to view emails" do
|
|
before { sign_in(moderator) }
|
|
|
|
it "denies access with a 403 response" do
|
|
get "/admin/logs/screened_emails.json"
|
|
|
|
expect(response.status).to eq(403)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("invalid_access"))
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#destroy" do
|
|
shared_examples "screened email deletion possible" do
|
|
it "deletes screened email" do
|
|
expect do delete "/admin/logs/screened_emails/#{screened_email.id}.json" end.to change {
|
|
ScreenedEmail.count
|
|
}.by(-1)
|
|
|
|
expect(response.status).to eq(200)
|
|
end
|
|
end
|
|
|
|
context "when logged in as an admin" do
|
|
before { sign_in(admin) }
|
|
|
|
include_examples "screened email deletion possible"
|
|
end
|
|
|
|
context "when logged in as a moderator and has permission to view emails" do
|
|
before do
|
|
sign_in(moderator)
|
|
SiteSetting.moderators_view_emails = true
|
|
end
|
|
|
|
include_examples "screened email deletion possible"
|
|
end
|
|
|
|
context "when logged in as a non-staff user" do
|
|
before { sign_in(user) }
|
|
|
|
it "prevents deletion with a 404 response" do
|
|
delete "/admin/logs/screened_emails/#{screened_email.id}.json"
|
|
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
|
|
end
|
|
end
|
|
|
|
context "when logged in as a moderator but no permission to view emails" do
|
|
before { sign_in(moderator) }
|
|
|
|
it "prevents deletion with a 403 response" do
|
|
delete "/admin/logs/screened_emails/#{screened_email.id}.json"
|
|
|
|
expect(response.status).to eq(403)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("invalid_access"))
|
|
end
|
|
end
|
|
end
|
|
end
|