mirror of
https://github.com/discourse/discourse.git
synced 2026-08-14 13:58:53 +08:00
6df9b0b357RSpec setup becomes harder to follow at either extreme: trivial fixture wrappers hide lifecycle and intent, while forcing every named operation inline repeats low-level protocol and configuration details. This change documents and applies a test-setup hierarchy: - use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according to lifecycle and role; - use a small example-group method when parameterized behavior gives one spec useful vocabulary; - move helpers into auto-loaded `spec/support` only when they are shared across spec files; - use fabricators and page objects for the data shapes and system-test interfaces they own. Core and plugin support files are loaded centrally by `rails_helper`, so plugin-specific support loaders are unnecessary. The migration specs encountered during the sweep are removed according to repository policy; production migrations are unchanged.
56 lines
1.8 KiB
Ruby
Vendored
56 lines
1.8 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
describe "Kick user from chat channel" do
|
|
fab!(:current_user, :user)
|
|
fab!(:channel_1, :chat_channel)
|
|
fab!(:channel_2, :chat_channel)
|
|
|
|
let(:chat) { PageObjects::Pages::Chat.new }
|
|
let(:channel) { PageObjects::Pages::ChatChannel.new }
|
|
let(:dialog) { PageObjects::Components::Dialog.new }
|
|
let(:sidebar_page) { PageObjects::Pages::ChatSidebar.new }
|
|
|
|
before do
|
|
SiteSetting.navigation_menu = "sidebar"
|
|
chat_system_bootstrap
|
|
sign_in(current_user)
|
|
channel_1.add(current_user)
|
|
channel_2.add(current_user)
|
|
end
|
|
|
|
context "when the user is looking at the channel they are kicked from" do
|
|
before { chat.visit_channel(channel_1) }
|
|
|
|
context "when the user presses ok" do
|
|
it "redirects them to the first other public channel they have" do
|
|
Chat::Publisher.publish_kick_users(channel_1.id, [current_user.id])
|
|
dialog.click_yes
|
|
expect(page).to have_current_path(channel_2.url)
|
|
end
|
|
|
|
context "when the user has no other public channels" do
|
|
before do
|
|
channel_2.remove(current_user)
|
|
chat.visit_channel(channel_1)
|
|
end
|
|
|
|
it "redirects them to the chat browse page" do
|
|
Chat::Publisher.publish_kick_users(channel_1.id, [current_user.id])
|
|
dialog.click_yes
|
|
expect(page).to have_current_path("/chat/browse/open")
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
context "when the user is not looking at the channel they are kicked from" do
|
|
before { chat.visit_channel(channel_2) }
|
|
|
|
it "removes it from their sidebar and does not redirect" do
|
|
Chat::Publisher.publish_kick_users(channel_1.id, [current_user.id])
|
|
expect(sidebar_page.channels_section).to have_no_css(
|
|
".sidebar-section-link.channel-#{channel_1.id}",
|
|
)
|
|
end
|
|
end
|
|
end
|
