discourse/lib/topics_bulk_action.rb
Régis Hanol c0e9377b0e
FEATURE: Bulk convert PMs to public topics (and vice versa) (#39256)
Adds two new staff-only bulk actions in the topic-list dropdown — "Make
Public Topic…" when every selected topic is a PM, and "Make Personal
Message" when none of them are. Both are silent by default: no bump, no
post revision, no edit notifications to watchers, no small-action post
in the topic, and no forced re-watch. Admins who do want to notify
participants can tick the existing "Notify" checkbox in the bulk-actions
modal.

Today, converting PMs to public topics is a one-at-a-time operation that
fans out noisy edit notifications to everyone watching the PM, creates a
post revision on the first post, and leaves a small-action post behind.
The Support team hits this whenever they move a customer's history out
of a group inbox and into an enterprise category — the existing runbook
(Ref - t/68360) works around it with a custom console script, and doing
it by hand spams participants. A proper bulk action in the UI was the
missing piece.

The plumbing starts at TopicConverter, which now takes a `silent:`
keyword argument. When true, it passes `bypass_bump`, `skip_revision`,
and `silent` through to PostRevisor (suppressing the bump, the revision
row, and the edit notifications), skips `add_small_action`, and skips
the forced `watch_topic` call at the end. While in there,
`convert_to_private_message` now fails loudly with a base error when the
final recipient count would exceed
`max_allowed_message_recipients`, rather than silently collapsing to a
self-only PM and losing all context — this applies to both the
single-topic and bulk paths, since the check lives in the converter
itself.

TopicsBulkAction registers two new operations,
`convert_to_public_topic` and `convert_to_private_message`, both driven
by a small `bulk_convert(from_pm:)` helper. Per-topic success is
detected from the archetype flip rather than from `.valid?`, which would
re-run validations and wipe the `errors.add(:base, ...)` added by the
cap guard. Validation errors bubble into the modal's failure list
through the existing `@errors` channel.

On the frontend, `bulk-select-topics-dropdown` gets two new entries with
matching visibility rules, and `bulk-topic-actions` gains a couple of
cases that reuse the existing CategoryChooser and `allowSilent`-backed
"Notify" checkbox. `isCategoryAction` is extended so the
destination-category picker renders for the PM→public flow.

Ref - t/181539
2026-04-21 15:08:39 +02:00

398 lines
9.7 KiB
Ruby

# frozen_string_literal: true
class TopicsBulkAction
attr_reader :errors
def initialize(user, topic_ids, operation, options = {})
@user = user
@topic_ids = topic_ids
@operation = operation
@changed_ids = []
@errors = Hash.new(0)
@options = options
end
def self.operations
@operations ||= %w[
change_category
close
archive
change_notification_level
destroy_post_timing
dismiss_posts
delete
unlist
archive_messages
move_messages_to_inbox
change_tags
append_tags
remove_tags
relist
dismiss_topics
reset_bump_dates
pin
unpin
convert_to_public_topic
convert_to_private_message
]
end
def self.register_operation(name, &block)
operations << name
define_method(name, &block)
end
def perform!
if TopicsBulkAction.operations.exclude?(@operation[:type])
raise Discourse::InvalidParameters.new(:operation)
end
# careful these are private methods, we need send
send(@operation[:type])
if @errors.present?
error_details = @errors.map { |msg, count| "- #{msg} (#{count} topics)" }.join("\n")
Rails.logger.warn(
"Bulk '#{@operation[:type]}' by @#{@user.username} (id=#{@user.id}) failed for #{@errors.values.sum} topics:\n#{error_details}",
)
end
@changed_ids.sort
end
private
def find_group
return unless @options[:group]
group = Group.where("name ilike ?", @options[:group]).first
raise Discourse::InvalidParameters.new(:group) unless group
unless group.group_users.where(user_id: @user.id).exists?
raise Discourse::InvalidParameters.new(:group)
end
group
end
def move_messages_to_inbox
group = find_group
topics.each do |t|
if guardian.can_see?(t) && t.private_message?
if group
GroupArchivedMessage.move_to_inbox!(group.id, t, acting_user_id: @user.id)
else
UserArchivedMessage.move_to_inbox!(@user.id, t)
end
@changed_ids << t.id
end
end
end
def archive_messages
group = find_group
topics.each do |t|
if guardian.can_see?(t) && t.private_message?
if group
GroupArchivedMessage.archive!(group.id, t, acting_user_id: @user.id)
else
UserArchivedMessage.archive!(@user.id, t)
end
@changed_ids << t.id
end
end
end
def dismiss_posts
highest_number_source_column =
@user.whisperer? ? "highest_staff_post_number" : "highest_post_number"
sql = <<~SQL
UPDATE topic_users tu
SET last_read_post_number = t.#{highest_number_source_column}
FROM topics t
WHERE t.id = tu.topic_id AND tu.user_id = :user_id AND t.id IN (:topic_ids)
SQL
DB.exec(sql, user_id: @user.id, topic_ids: @topic_ids)
TopicTrackingState.publish_dismiss_new_posts(@user.id, topic_ids: @topic_ids.sort)
@changed_ids.concat @topic_ids
end
def dismiss_topics
ids =
Topic
.where(id: @topic_ids)
.joins(
"LEFT JOIN topic_users ON topic_users.topic_id = topics.id AND topic_users.user_id = #{@user.id}",
)
.where("topics.created_at >= ?", dismiss_topics_since_date)
.where("topic_users.last_read_post_number IS NULL")
.order("topics.created_at DESC")
.limit(SiteSetting.max_new_topics)
.filter { |t| guardian.can_see?(t) }
.map(&:id)
if ids.present?
now = Time.zone.now
rows = ids.map { |id| { topic_id: id, user_id: @user.id, created_at: now } }
DismissedTopicUser.insert_all(rows)
TopicTrackingState.publish_dismiss_new(@user.id, topic_ids: ids.sort)
end
@changed_ids = ids
end
def destroy_post_timing
topics.each do |t|
PostTiming.destroy_last_for(@user, topic: t)
@changed_ids << t.id
end
end
def change_category
updatable_topics = topics.where.not(category_id: @operation[:category_id])
opts = {
bypass_bump: true,
validate_post: false,
bypass_rate_limiter: true,
silent: @operation[:silent],
skip_revision: !SiteSetting.create_revision_on_bulk_topic_moves,
}
updatable_topics.each do |t|
if guardian.can_edit?(t)
changes = { category_id: @operation[:category_id] }
if t.first_post.revise(@user, changes, opts)
@changed_ids << t.id
else
t.errors.full_messages.each { |msg| @errors[msg] += 1 }
end
end
end
end
def convert_to_public_topic
bulk_convert(from_pm: true) { |c| c.convert_to_public_topic(@operation[:category_id]) }
end
def convert_to_private_message
bulk_convert(from_pm: false, &:convert_to_private_message)
end
def bulk_convert(from_pm:)
silent = @operation.fetch(:silent, true)
topics.each do |t|
next if t.private_message? != from_pm
next unless guardian.can_convert_topic?(t)
yield TopicConverter.new(t, @user, silent: silent)
if t.errors.any?
t.errors.full_messages.each { |msg| @errors[msg] += 1 }
elsif t.reload.private_message? != from_pm
@changed_ids << t.id
end
end
end
def change_notification_level
notification_level_id = @operation[:notification_level_id]
raise Discourse::InvalidParameters.new(:notification_level_id) if notification_level_id.blank?
topics.each do |t|
if guardian.can_see?(t)
TopicUser.change(@user, t.id, notification_level: notification_level_id.to_i)
@changed_ids << t.id
end
end
end
def close
topics.each do |t|
if guardian.can_moderate?(t)
t.update_status(
"closed",
true,
@user,
{ message: @operation[:message], silent_tracking: @operation[:silent] },
)
@changed_ids << t.id
end
end
end
def unlist
topics.each do |t|
if guardian.can_moderate?(t)
t.update_status(
"visible",
false,
@user,
{ visibility_reason_id: Topic.visibility_reasons[:bulk_action] },
)
@changed_ids << t.id
end
end
end
def relist
topics.each do |t|
if guardian.can_moderate?(t)
t.update_status(
"visible",
true,
@user,
{ visibility_reason_id: Topic.visibility_reasons[:bulk_action] },
)
@changed_ids << t.id
end
end
end
def reset_bump_dates
if guardian.can_update_bumped_at?
topics.each do |t|
t.reset_bumped_at
@changed_ids << t.id
end
end
end
def pin
status = @operation[:pinned_globally] ? "pinned_globally" : "pinned"
topics.each do |t|
if guardian.can_moderate?(t)
t.update_status(status, true, @user, until: @operation[:pinned_until])
@changed_ids << t.id
end
end
end
def unpin
topics.each do |t|
if guardian.can_moderate?(t) && t.pinned_at
status = t.pinned_globally ? "pinned_globally" : "pinned"
t.update_status(status, false, @user)
@changed_ids << t.id
end
end
end
def archive
topics.each do |t|
if guardian.can_moderate?(t)
t.update_status("archived", true, @user)
@changed_ids << t.id
end
end
end
def delete
topics.each do |t|
if guardian.can_delete?(t)
post = t.ordered_posts.first
PostDestroyer.new(@user, post).destroy if post
end
end
end
def change_tags
tags = resolve_tag_names || []
topics_with_tags.each do |t|
next unless guardian.can_edit?(t)
next unless t.first_post
if t.first_post.revise(@user, { tags: tags }, bulk_tag_opts)
@changed_ids << t.id
else
t.errors.full_messages.each { |msg| @errors[msg] += 1 }
end
end
end
def append_tags
tags = resolve_tag_names || []
return if tags.blank?
topics_with_tags.each do |t|
next unless guardian.can_edit?(t)
next unless t.first_post
merged = t.tags.map(&:name) | tags
if t.first_post.revise(@user, { tags: merged }, bulk_tag_opts)
@changed_ids << t.id
else
t.errors.full_messages.each { |msg| @errors[msg] += 1 }
end
end
end
def remove_tags
topics_with_tags.each do |t|
next unless guardian.can_edit?(t)
next unless t.first_post
if t.first_post.revise(@user, { tags: [] }, bulk_tag_opts)
@changed_ids << t.id
else
t.errors.full_messages.each { |msg| @errors[msg] += 1 }
end
end
end
def resolve_tag_names
if @operation[:tag_ids].present?
Tag.where(id: @operation[:tag_ids]).pluck(:name)
elsif @operation[:tags].present?
Discourse.deprecate(
"the tags param for bulk actions is deprecated, use tag_ids instead",
since: "2026.01",
drop_from: "2026.07",
)
@operation[:tags]
end
end
def bulk_tag_opts
{
bypass_bump: true,
validate_post: false,
bypass_rate_limiter: true,
skip_revision: true,
silent: true,
}
end
def guardian
@guardian ||= Guardian.new(@user)
end
def topics
@topics ||= Topic.where(id: @topic_ids)
end
def topics_with_tags
@topics_with_tags ||= topics.includes(:first_post, :tags)
end
def dismiss_topics_since_date
new_topic_duration_minutes =
@user.user_option&.new_topic_duration_minutes ||
SiteSetting.default_other_new_topic_duration_minutes
setting_date =
case new_topic_duration_minutes
when User::NewTopicDuration::LAST_VISIT
@user.previous_visit_at || @user.created_at
when User::NewTopicDuration::ALWAYS
@user.created_at
else
new_topic_duration_minutes.minutes.ago
end
[setting_date, @user.created_at, Time.at(SiteSetting.min_new_topics_time).to_datetime].max
end
end