Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-04 20:35:52 +08:00
Code Packages Activity Actions
discourse/.skills/discourse-upcoming-changes-authoring
History
Exact
Martin Brennan d6aa4f59c3
FIX: Admin modified setting from old default being clobbered by upcoming change default (#39279) 
Followup dd8c16cbd6

I found this issue when testing
https://github.com/discourse/discourse/pull/39250

This is how to reproduce:

* First enable the upcoming change to change discourse_reactions_enabled
  default to true from false
* Go to site settings and find discourse_reactions_enabled
* See that it is enabled by default. Now uncheck it to disable
  and save
* Reload the page. See that it still appears to be enabled and
  doesn't show the overridden dot

This was happening because in SiteSetting.refresh!, we are disregarding
site settings from being considered modified when their value in
the DB is the same as the default value. However this comparison
was made against the _original_ default value, not the upcoming
change overridden one, so the admin's choice ended up being clobbered
by the new default.

This commit fixes the issue, tested against the linked PR for reactions
too
2026-04-17 09:55:29 +10:00
..
SKILL.md FIX: Admin modified setting from old default being clobbered by upcoming change default (#39279) 2026-04-17 09:55:29 +10:00