0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-11 02:59:07 +08:00
discourse/plugins/poll/test/javascripts/component/poll-ui-builder-test.gjs
Kris 9433cadcdb
UX: refactor advanced mode toggle to shared component (#41138)
Events, Polls, and Dates all have "advanced mode" toggles, but they're
all just a little different. This unifies them behind one reusable core
component. Now they're all consisently toggling between "advanced mode"
and "simple mode"

Before:
<img width="700" alt="image"
src="https://github.com/user-attachments/assets/0b92e8f1-1dd0-4617-8ab6-6d968ca980cc"
/>
<img width="350" alt="image"
src="https://github.com/user-attachments/assets/d02a8464-b782-4c1e-a7f0-d1a90e87798d"
/>
<img width="800" alt="image"
src="https://github.com/user-attachments/assets/f5d074d3-0e32-41e6-a3fb-f6a3b0f32ae3"
/>



After: 
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/c25cd693-d4e7-4906-a346-197dcf6d5f6e"
/>
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/a3e1d7c3-f796-448d-83bb-cae611114030"
/>
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/90eecacb-9868-4fd3-b74f-722b32b9425e"
/>
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/881b5a8a-7731-40f1-af33-ba6bc94910de"
/>
2026-06-24 09:34:04 -04:00

245 lines
7.5 KiB
Text
Vendored

import { click, fillIn, render } from "@ember/test-helpers";
import { module, test } from "qunit";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import selectKit from "discourse/tests/helpers/select-kit-helper";
import PollUiBuilder from "discourse/plugins/poll/discourse/components/modal/poll-ui-builder";
async function setupBuilder() {
const noop = () => {};
const results = [];
const model = {
toolbarEvent: { getText: () => "", addText: (t) => results.push(t) },
};
await render(
<template>
<PollUiBuilder @inline={{true}} @model={{model}} @closeModal={{noop}} />
</template>
);
return results;
}
module("Component | PollUiBuilder", function (hooks) {
setupRenderingTest(hooks);
test("Can switch poll type", async function (assert) {
await setupBuilder();
assert.dom(".poll-type-value-regular").hasClass("active");
await click(".poll-type-value-multiple");
assert
.dom(".poll-type-value-multiple")
.hasClass("active", "can switch to 'multiple' type");
assert
.dom(".poll-type-value-number")
.doesNotExist("number type is hidden by default");
await click(".advanced-mode-btn");
assert
.dom(".poll-type-value-number")
.exists("number type appears in advanced mode");
await click(".poll-type-value-number");
assert
.dom(".poll-type-value-number")
.hasClass("active", "can switch to 'number' type");
});
test("Automatically updates min/max when number of options change", async function (assert) {
await setupBuilder();
await click(".poll-type-value-multiple");
assert.dom(".poll-options-min").hasValue("0");
assert.dom(".poll-options-max").hasValue("0");
await fillIn(".poll-option-value input", "a");
assert.dom(".poll-options-min").hasValue("1");
assert.dom(".poll-options-max").hasValue("1");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(2) input", "b");
assert.dom(".poll-options-min").hasValue("1");
assert.dom(".poll-options-max").hasValue("2");
});
test("disables save button", async function (assert) {
this.siteSettings.poll_maximum_options = 3;
await setupBuilder();
assert
.dom(".insert-poll")
.isDisabled("Insert button disabled when no options specified");
await fillIn(".poll-option-value input", "a");
assert
.dom(".insert-poll")
.isEnabled("Insert button enabled once an option is specified");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(2) input", "b");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(3) input", "c");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(4) input", "d");
assert
.dom(".insert-poll")
.isDisabled("Insert button disabled when too many options");
});
test("number mode", async function (assert) {
const results = await setupBuilder();
await click(".advanced-mode-btn");
await click(".poll-type-value-number");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=number results=always min=1 max=20 step=1 public=true]\n[/poll]\n"
);
await fillIn(".poll-options-step", "2");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=number results=always min=1 max=20 step=2 public=true]\n[/poll]\n",
"includes step value"
);
await click(".poll-toggle-public");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=number results=always min=1 max=20 step=2 public=false]\n[/poll]\n",
"can be set to private"
);
await fillIn(".poll-options-step", "0");
assert
.dom(".insert-poll")
.isDisabled("Insert button disabled when step is 0");
});
test("regular mode", async function (assert) {
const results = await setupBuilder();
await fillIn(".poll-option-value input", "a");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(2) input", "b");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=regular results=always public=true chartType=bar]\n* a\n* b\n[/poll]\n",
"has correct output"
);
await click(".advanced-mode-btn");
await click(".poll-toggle-public");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=regular results=always public=false chartType=bar]\n* a\n* b\n[/poll]\n",
"can be set to private"
);
await click(".poll-toggle-dynamic");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=regular results=always public=false chartType=bar dynamic=true]\n* a\n* b\n[/poll]\n",
"includes dynamic=true when enabled"
);
await click(".poll-toggle-dynamic");
const groupChooser = selectKit(".group-chooser");
await groupChooser.expand();
await groupChooser.selectRowByName("custom_group");
await groupChooser.collapse();
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=regular results=always public=false chartType=bar groups=custom_group]\n* a\n* b\n[/poll]\n",
"has groups"
);
});
test("multi-choice mode", async function (assert) {
const results = await setupBuilder();
await click(".poll-type-value-multiple");
await fillIn(".poll-option-value input", "a");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(2) input", "b");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=multiple results=always min=1 max=2 public=true chartType=bar]\n* a\n* b\n[/poll]\n",
"has correct output"
);
await click(".advanced-mode-btn");
await click(".poll-toggle-public");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=multiple results=always min=1 max=2 public=false chartType=bar]\n* a\n* b\n[/poll]\n",
"can be set to private boolean"
);
});
test("staff_only option is not present for non-staff", async function (assert) {
await setupBuilder();
await click(".advanced-mode-btn");
const resultVisibility = selectKit(".poll-result");
assert.strictEqual(resultVisibility.header().value(), "always");
await resultVisibility.expand();
assert.false(
resultVisibility.rowByValue("staff_only").exists(),
"staff_only is not visible to normal users"
);
await resultVisibility.collapse();
this.currentUser.setProperties({ admin: true });
await resultVisibility.expand();
assert.true(
resultVisibility.rowByValue("staff_only").exists(),
"staff_only is visible to staff"
);
await resultVisibility.collapse();
});
test("default public value can be controlled with site setting", async function (assert) {
this.siteSettings.poll_default_public = false;
const results = await setupBuilder();
await fillIn(".poll-option-value input", "a");
await click(".poll-option-add");
await fillIn(".poll-option-value:nth-of-type(2) input", "b");
await click(".insert-poll");
assert.strictEqual(
results[results.length - 1],
"[poll type=regular results=always public=false chartType=bar]\n* a\n* b\n[/poll]\n",
"can be set to private boolean"
);
});
});