Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-04 10:39:43 +08:00
Code Packages Activity Actions
discourse/frontend
History
Exact
Kris 665494fc53
 DEV: simplify and use reuable components in invite modal, fix bug, (#42273) 
We were creating some new conventions here instead of relying on
existing components. This gets the invite modal on more shared
components, reduces the custom css, and fixes the bug reported here:
https://meta.discourse.org/t/invite-restricted-cant-remove/409058

reusing existing components
- segment control 
- formkit conditional section
- advanced mode toggle  


Removed some redundant text: 
"invite people to join this site" — what else would you be inviting
people to?
"share a link or send an email invitation" – that's what the radio
options already indicate
"to invite a specific person, use email above" – that's implied by
"email"

before
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/1cdb474c-e393-4066-854f-3b6d714b0195"
/>

after
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/506229b7-88fe-437f-8a2d-db3618814c48"
/>


I've also triggered the success button on the copy button on the second
step, as an indication that the link has been copied successfully.

<img width="600" alt="image"
src="https://github.com/user-attachments/assets/52c9ef8d-94ea-4b11-923d-9e5745a7e53e"
/>


Changed the order here so the descriptions are associated with the
selection and below them (rather than being above them, which is awkward
for reading order)

Removed "invite people to join your staff team" which was redundant, the
roles describe what kind of access you're inviting — also elaborated a
little to make the full admin scope more apparent

before
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/9f4684ec-b2d0-43d6-92b7-23dd27156f77"
/>


after
<img width="600" alt="image"
src="https://github.com/user-attachments/assets/b7af2317-21c4-4b0c-809a-c4ac13c218e3"
/>


Mobile also fits slightly better on the tiniest screens at 320px wide 

before
<img width="320" alt="image"
src="https://github.com/user-attachments/assets/11e61205-f3a6-4f68-a8ea-0c1ef75b9aa1"
/>

after
<img width="320" alt="image"
src="https://github.com/user-attachments/assets/b2caef7d-5562-452f-8d51-6c9af779a809"
/>
2026-08-03 15:31:55 -04:00
..
asset-processor DEV: Derive styleguide code samples from the rendered example (#42100) 2026-07-29 13:48:35 -03:00
deprecation-silencer
discourse DEV: simplify and use reuable components in invite modal, fix bug, (#42273) 2026-08-03 15:31:55 -04:00
discourse-i18n DEV: add typescript support for core, themes and plugins (#41478) 2026-07-08 12:57:18 +01:00
discourse-markdown-it DEV: Bump eslint/lint-configs, and correct violations (#41321) 2026-07-01 10:39:57 +01:00
discourse-types DEV: Use bundler module resolution for @discourse/types consumers (#41661) 2026-07-13 21:43:39 -03:00
pretty-text FIX: clean up onebox loading decorations on fetch failure (#39277) 2026-07-23 19:50:41 -03:00
.npmrc
polyfills.js