mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-04 17:02:35 +08:00
8c0a4bb8f9
## Summary Patreon API v1 has been deprecated for years and the Patreon team has requested we migrate to v2 (see https://meta.discourse.org/t/upgrade-patreon-discourse-plugin-to-api-v2/386701). Since hundreds of existing customers have v1 OAuth clients, this PR supports **both versions simultaneously** via an adapter pattern, controlled by a new `patreon_api_version` site setting (defaults to `"1"` so no one breaks on upgrade). ### What changed - **Adapter pattern**: `Patreon::ApiVersion::V1` and `ApiVersion::V2` modules with identical interfaces for endpoints, response parsing, and OAuth config. `ApiVersion.current` routes based on the site setting. - **v2 API support**: campaigns endpoint returns tiers (not rewards), members fetched separately with cursor-based pagination, v2 identity endpoint with explicit field selection, v2 OAuth scopes - **Webhooks accept both formats**: payload version detected from `data.type` (`"pledge"` → v1, `"member"` → v2), regardless of the site setting - **Admin deprecation notice**: `ProblemCheck::PatreonApiV1Deprecated` warns on the dashboard when still using v1 - **Shared logic unchanged**: rate limiting, PluginStore, group sync, admin UI all version-agnostic - Also fixes pre-existing flaky seed/campaign spec failures ### Migration path for existing users 1. Admin sees deprecation warning on dashboard 2. Create a new v2 OAuth client at https://www.patreon.com/portal/registration/register-clients 3. Update credentials in site settings 4. Switch `patreon_api_version` to `"2"` 5. Creator re-authenticates via Patreon login to get v2-scoped tokens 6. Trigger a manual data sync from the Patreon admin panel ### Future v1 removal When ready to drop v1: delete `lib/api_version/v1.rb`, the problem check, the site setting, v1 fixtures, and v1 test contexts — one clean cut. ## Test plan - [x] All 41 plugin specs pass (both v1 and v2 contexts) - [x] Lint passes on all changed files - [x] Zeitwerk reload passes (`bin/rails runner "Rails.application.reloader.reload!"`) - [x] Manual testing with a real Patreon v2 OAuth client
34 lines
723 B
JSON
34 lines
723 B
JSON
{
|
|
"data": {
|
|
"attributes": {
|
|
"currently_entitled_amount_cents": 250,
|
|
"last_charge_date": "2015-05-18T23:50:42+00:00",
|
|
"last_charge_status": "Paid",
|
|
"patron_status": "active_patron",
|
|
"email": "roo@aar.com"
|
|
},
|
|
"id": "d485d5ac-6c82-42c6-9c08-c50cf01b73d7",
|
|
"relationships": {
|
|
"currently_entitled_tiers": {
|
|
"data": [{ "id": "999999", "type": "tier" }]
|
|
},
|
|
"user": {
|
|
"data": {
|
|
"id": "32187",
|
|
"type": "user"
|
|
}
|
|
}
|
|
},
|
|
"type": "member"
|
|
},
|
|
"included": [
|
|
{
|
|
"attributes": {
|
|
"email": "roo@aar.com",
|
|
"full_name": "Roo Aar"
|
|
},
|
|
"id": "32187",
|
|
"type": "user"
|
|
}
|
|
]
|
|
}
|
