mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-27 18:59:19 +08:00
89f26da39d
Ruby's compact module syntax (`module Migrations::Database::Schema::DSL`) breaks lexical constant lookup — `Module.nesting` only includes the innermost constant, so every cross-module reference must be fully qualified. In practice this means writing `Migrations::Database::Schema::Helpers` even when you're already inside `Migrations::Database::Schema`. Nested module definitions restore the full nesting chain, which brings several practical benefits: - **Less verbose code**: references like `Schema::Helpers`, `Database::IntermediateDB`, or `Converters::Base::ProgressStep` work without repeating the full path from root - **Easier to write new code**: contributors don't need to remember which prefixes are required — if you're inside the namespace, short names just work - **Fewer aliasing workarounds**: removes the need for constants like `MappingType = Migrations::Importer::MappingType` that existed solely to shorten references - **Standard Ruby style**: consistent with how most Ruby projects and gems structure their namespaces The diff is large but mechanical — no logic changes, just module wrapping and shortening references that the nesting now resolves. Generated code (intermediate_db models/enums) keeps fully qualified references like `Migrations::Database.format_*` since it must work regardless of the configured output namespace. - Convert 138 lib files from compact to nested module definitions - Remove now-redundant fully qualified prefixes and aliases - Update model and enum writers to generate nested modules with correct indentation - Regenerate all intermediate_db models and enums
60 lines
2.1 KiB
Ruby
Vendored
60 lines
2.1 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
module Migrations
|
|
module Importer
|
|
module Steps
|
|
class GroupUsers < CopyStep
|
|
NOTIFICATION_LEVELS = GroupUser.notification_levels.values.to_set.freeze
|
|
DEFAULT_NOTIFICATION_LEVEL = GroupUser.notification_levels[:tracking]
|
|
|
|
depends_on :groups, :users
|
|
|
|
requires_set :existing_group_users,
|
|
"SELECT group_id, user_id FROM group_users WHERE user_id > 0"
|
|
|
|
column_names %i[group_id user_id created_at updated_at owner notification_level]
|
|
|
|
total_rows_query <<~SQL, MappingType::GROUPS, MappingType::USERS
|
|
SELECT COUNT(*)
|
|
FROM group_users
|
|
JOIN mapped.ids mapped_groups
|
|
ON group_users.group_id = mapped_groups.original_id AND mapped_groups.type = ?1
|
|
JOIN mapped.ids mapped_users
|
|
ON group_users.user_id = mapped_users.original_id AND mapped_users.type = ?2
|
|
SQL
|
|
|
|
rows_query <<~SQL, MappingType::GROUPS, MappingType::USERS
|
|
SELECT group_users.*,
|
|
mapped_groups.discourse_id AS discourse_group_id,
|
|
mapped_users.discourse_id AS discourse_user_id
|
|
FROM group_users
|
|
JOIN mapped.ids mapped_groups
|
|
ON group_users.group_id = mapped_groups.original_id AND mapped_groups.type = ?1
|
|
JOIN mapped.ids mapped_users
|
|
ON group_users.user_id = mapped_users.original_id AND mapped_users.type = ?2
|
|
ORDER BY discourse_group_id, discourse_user_id
|
|
SQL
|
|
|
|
private
|
|
|
|
def transform_row(row)
|
|
group_id = row[:discourse_group_id]
|
|
user_id = row[:discourse_user_id]
|
|
|
|
return nil unless @existing_group_users.add?(group_id, user_id)
|
|
|
|
row[:owner] ||= false
|
|
row[:group_id] = group_id
|
|
row[:user_id] = user_id
|
|
row[:notification_level] = ensure_valid_value(
|
|
value: row[:notification_level],
|
|
allowed_set: NOTIFICATION_LEVELS,
|
|
default_value: DEFAULT_NOTIFICATION_LEVEL,
|
|
)
|
|
|
|
super
|
|
end
|
|
end
|
|
end
|
|
end
|
|
end
|
