mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-02 06:48:58 +08:00
This commit introduces a Rails initializer to inspect
the current status of upcoming changes and compare them
to a hidden `promote_upcoming_changes_on_status` site setting.
If the status of an upcoming change matches or exceeds this setting,
the change is automatically enabled as long as:
* The change has not been manually disabled by an admin.
* The change is not already enabled.
By default for Discourse sites, the `promote_upcoming_changes_on_status`
is set to `Stable`, on our own hosting we will change it depending
on the hosting tier and other considerations.
In a future PR, we will introduce various ways for admins to
be notified when an upcoming change is automatically promoted,
along with new upcoming changes being introduced.
**HOW TO TEST**
This is a little tricky, since it happens on rails init. First, set
`SiteSetting.enable_upcoming_changes = true` and
`SiteSetting.upcoming_change_verbose_logging = true`.
You can also set `SiteSetting.promote_upcoming_changes_on_status =
:alpha`
(by default it's `stable`)
Then, add a change like this to site_settings.yml:
```
fake_upcoming_change:
default: false
hidden: true
client: true
upcoming_change:
status: "alpha"
impact: "other,all_members"
learn_more_url: "https://meta.discourse.org"
```
And then do ` FORCE_RAILS_LOGS_STDOUT=1 brc`. After this, you should see
output like this:
```
I, [2025-11-26T16:46:54.668551 #32662] INFO -- : [Upcoming changes promoter (default)]: Starting promotion check for upcoming changes.
I, [2025-11-26T16:46:54.733353 #32662] INFO -- : [Upcoming changes promoter (default)]: Successfully promoted 'fake_upcoming_change' to enabled.
```
If you want to reset the setting and try some different status
scenarios, do
this `SiteSetting.remove_override!(:fake_upcoming_change)`
141 lines
4.8 KiB
Ruby
141 lines
4.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
if GlobalSetting.skip_redis?
|
|
Rails.application.reloader.to_prepare do
|
|
Rails.logger.stop_broadcasting_to(Logster.logger) if defined?(Logster::Logger) && Logster.logger
|
|
end
|
|
return
|
|
end
|
|
|
|
if (Rails.env.local?) && ENV["FORCE_RAILS_LOGS_STDOUT"] == "1"
|
|
Rails.logger = Logger.new(STDOUT)
|
|
return
|
|
end
|
|
|
|
if Rails.env.development? && !Sidekiq.server? && ENV["RAILS_LOGS_STDOUT"] == "1"
|
|
Rails.application.config.after_initialize do
|
|
console = ActiveSupport::Logger.new(STDOUT)
|
|
original_logger = Rails.logger.broadcasts.first
|
|
console.formatter = original_logger.formatter
|
|
console.level = original_logger.level
|
|
|
|
unless ActiveSupport::Logger.logger_outputs_to?(original_logger, STDOUT)
|
|
Rails.logger.broadcast_to(console)
|
|
end
|
|
end
|
|
end
|
|
|
|
if Rails.env.production?
|
|
Logster.store.ignore = [
|
|
# These errors are caused by client requests. No need to log them.
|
|
# Rails itself defines these as 'silent exceptions', but this does
|
|
# not entirely prevent them from being logged
|
|
# https://github.com/rails/rails/blob/f2caed1e/actionpack/lib/action_dispatch/middleware/exception_wrapper.rb#L39-L42
|
|
/^ActionController::RoutingError \(No route matches/,
|
|
/^ActionDispatch::Http::MimeNegotiation::InvalidType/,
|
|
/^PG::Error: ERROR:\s+duplicate key/,
|
|
/^ActionController::UnknownFormat/,
|
|
/^ActionController::UnknownHttpMethod/,
|
|
/^AbstractController::ActionNotFound/,
|
|
# ignore any empty JS errors that contain blanks or zeros for line and column fields
|
|
#
|
|
# Line:
|
|
# Column:
|
|
#
|
|
/(?m).*?Line: (?:\D|0).*?Column: (?:\D|0)/,
|
|
# suppress empty JS errors (covers MSIE 9, etc)
|
|
/^(Syntax|Script) error.*Line: (0|1)\b/m,
|
|
# CSRF errors are not providing enough data
|
|
# suppress unconditionally for now
|
|
/^Can't verify CSRF token authenticity.$/,
|
|
# Yandex bot triggers this JS error a lot
|
|
/^Uncaught ReferenceError: I18n is not defined/,
|
|
# related to browser plugins somehow, we don't care
|
|
/Error calling method on NPObject/,
|
|
# 404s can be dealt with elsewhere
|
|
/^ActiveRecord::RecordNotFound/,
|
|
# bad asset requested, no need to log
|
|
/^ActionController::BadRequest/,
|
|
# we can't do anything about invalid parameters
|
|
/Rack::QueryParser::InvalidParameterError/,
|
|
# we handle this cleanly in the message bus middleware
|
|
# no point logging to logster
|
|
/RateLimiter::LimitExceeded.*/m,
|
|
# Pitchfork workers call Process.exit when timeouting
|
|
/SystemExit/,
|
|
]
|
|
Logster.config.env_expandable_keys.push(:hostname, :problem_db)
|
|
end
|
|
|
|
Rails.application.config.after_initialize do
|
|
Logster.config.back_to_site_link_path = "#{Discourse.base_path}/admin"
|
|
Logster.config.back_to_site_link_text = I18n.t("dashboard.back_from_logster_text")
|
|
end
|
|
|
|
Logster.store.max_backlog = GlobalSetting.max_logster_logs
|
|
|
|
# TODO logster should be able to do this automatically
|
|
Logster.config.subdirectory = "#{GlobalSetting.relative_url_root}/logs"
|
|
|
|
Logster.config.application_version = Discourse.git_version
|
|
Logster.config.enable_custom_patterns_via_ui = true
|
|
Logster.config.use_full_hostname = true
|
|
Logster.config.enable_js_error_reporting = GlobalSetting.enable_js_error_reporting
|
|
|
|
store = Logster.store
|
|
redis = Logster.store.redis
|
|
store.redis_prefix = Proc.new { redis.namespace }
|
|
store.redis_raw_connection = redis.without_namespace
|
|
severities = [Logger::WARN, Logger::ERROR, Logger::FATAL, Logger::UNKNOWN]
|
|
|
|
RailsMultisite::ConnectionManagement.safe_each_connection do
|
|
error_rate_per_minute =
|
|
begin
|
|
SiteSetting.alert_admins_if_errors_per_minute
|
|
rescue StandardError
|
|
0
|
|
end
|
|
|
|
if (error_rate_per_minute || 0) > 0
|
|
store.register_rate_limit_per_minute(severities, error_rate_per_minute) do |rate|
|
|
MessageBus.publish(
|
|
"/logs_error_rate_exceeded",
|
|
{ rate: rate, duration: "minute", publish_at: Time.current.to_i },
|
|
group_ids: [Group::AUTO_GROUPS[:admins]],
|
|
)
|
|
end
|
|
end
|
|
|
|
error_rate_per_hour =
|
|
begin
|
|
SiteSetting.alert_admins_if_errors_per_hour
|
|
rescue StandardError
|
|
0
|
|
end
|
|
|
|
if (error_rate_per_hour || 0) > 0
|
|
store.register_rate_limit_per_hour(severities, error_rate_per_hour) do |rate|
|
|
MessageBus.publish(
|
|
"/logs_error_rate_exceeded",
|
|
{ rate: rate, duration: "hour", publish_at: Time.current.to_i },
|
|
group_ids: [Group::AUTO_GROUPS[:admins]],
|
|
)
|
|
end
|
|
end
|
|
end
|
|
|
|
if Rails.configuration.multisite
|
|
Rails.logger.broadcasts.first.formatter = RailsMultisite::Formatter.new
|
|
end
|
|
|
|
Logster.config.project_directories = [
|
|
{ path: Rails.root.to_s, url: "https://github.com/discourse/discourse", main_app: true },
|
|
]
|
|
Discourse.plugins.each do |plugin|
|
|
next if !plugin.metadata.url
|
|
|
|
Logster.config.project_directories << {
|
|
path: "#{Rails.root}/plugins/#{plugin.directory_name}",
|
|
url: plugin.metadata.url,
|
|
}
|
|
end
|