discourse/app/models/application_request.rb
David Taylor 3332e9f4c3
DEV: Always pass --force to annotaterb and reorder annotations (#39977)
`.annotaterb.yml` has carried `classified_sort: true` since the project
switched from `annotate` to `annotaterb` (commit 0eab7daea4, July 2025),
but annotaterb's default behaviour is to compare the existing schema
block against what it would generate and skip the rewrite when the
column list matches — even when the *ordering* of those columns differs.
The result is that models which haven't had a schema change since the
config landed never get reordered, and `classified_sort` drift
accumulates indefinitely.

`--force` makes annotaterb always rewrite, so a single `bin/rake
annotate:clean` run brings every model into the canonical format and
keeps them there. Every schema block is now grouped primary-key →
regular columns → timestamps → foreign keys (alphabetical within each
group). Pure annotation comment change — no code modifications.

Also cleans up the rake task to avoid string interpolation for `system`
calls.
2026-05-13 14:12:48 +01:00

93 lines
2.5 KiB
Ruby

# frozen_string_literal: true
class ApplicationRequest < ActiveRecord::Base
enum :req_type,
{
http_total: 0,
http_2xx: 1,
http_background: 2,
http_3xx: 3,
http_4xx: 4,
http_5xx: 5,
page_view_crawler: 6,
page_view_logged_in: 7,
page_view_anon: 8,
page_view_logged_in_mobile: 9,
page_view_anon_mobile: 10,
api: 11,
user_api: 12,
page_view_anon_browser: 13,
page_view_anon_browser_mobile: 14,
page_view_logged_in_browser: 15,
page_view_logged_in_browser_mobile: 16,
page_view_anon_browser_beacon: 17,
page_view_anon_browser_mobile_beacon: 18,
page_view_logged_in_browser_beacon: 19,
page_view_logged_in_browser_mobile_beacon: 20,
page_view_embed: 21,
}
include CachedCounting
def self.disable
@disabled = true
end
def self.enable
@disabled = false
end
def self.increment!(req_type)
return if @disabled
perform_increment!(req_type)
end
def self.write_cache!(req_type, count, date)
req_type_id = req_types[req_type]
DB.exec(<<~SQL, date: date, req_type_id: req_type_id, count: count)
INSERT INTO application_requests (date, req_type, count)
VALUES (:date, :req_type_id, :count)
ON CONFLICT (date, req_type)
DO UPDATE SET count = application_requests.count + excluded.count
SQL
end
def self.stats
s = ActiveSupport::HashWithIndifferentAccess.new({})
self.req_types.each do |key, i|
query = self.where(req_type: i)
s["#{key}_total"] = query.sum(:count)
s["#{key}_30_days"] = query.where("date > ?", 30.days.ago).sum(:count)
s["#{key}_28_days"] = query.where("date > ?", 28.days.ago).sum(:count)
s["#{key}_7_days"] = query.where("date > ?", 7.days.ago).sum(:count)
end
s
end
def self.request_type_count_for_period(type, since)
id = self.req_types[type]
if !id
raise ArgumentError.new(
"unknown request type #{type.inspect} in ApplicationRequest.req_types",
)
end
self.where(req_type: id).where("date >= ?", since).sum(:count)
end
end
# == Schema Information
#
# Table name: application_requests
#
# id :integer not null, primary key
# count :integer default(0), not null
# date :date not null
# req_type :integer not null
#
# Indexes
#
# index_application_requests_on_date_and_req_type (date,req_type) UNIQUE
#