discourse/app/controllers/admin/groups_controller.rb
Natalie Tay 8980779ae5
FIX: Ensure moderators do not clear group email domain (#39631)
When a moderator (who can manage groups via `moderators_manage_groups`)
edits a group's profile and saves, the
`automatic_membership_email_domains` gets silently cleared now.

One issue that leads to another:
- `GroupShowSerializer gated automatic_membership_email_domains` behind
`is_admin?`, so moderators never received the value. The frontend model
defaulted to "", and on save ... 💥 (it gets cleared)
- -> Then, the "save" flow calls
`/admin/groups/automatic_membership_count.json` to check if new users
would be auto-added, but that route sat behind `AdminConstraint`, so
moderators got a 404.

This PR fixes by using `can_admin_group?` visibility check (covers
admins + moderators with the setting enabled), and moving the
`automatic_membership_count` route to the staff-accessible block +
adding a `can_create_group?` guard in the controller so moderators
without moderators_manage_groups still can't access it.
2026-04-29 14:32:38 +08:00

148 lines
4.1 KiB
Ruby

# frozen_string_literal: true
class Admin::GroupsController < Admin::StaffController
MAX_AUTO_MEMBERSHIP_DOMAINS_LOOKUP = 10
def index
end
def create
Groups::Create.call(
guardian:,
params: group_params.except(*DiscoursePluginRegistry.group_params),
options: {
dynamic_attributes: group_params.slice(*DiscoursePluginRegistry.group_params),
},
) do |result|
on_success { |group:| render_serialized(group, BasicGroupSerializer) }
on_failed_policy(:can_create_group) { |policy| raise Discourse::InvalidAccess }
on_failure { render(json: failed_json, status: :unprocessable_entity) }
end
end
def destroy
group = Group.find_by(id: params[:id])
raise Discourse::NotFound unless group
if group.automatic
can_not_modify_automatic
else
StaffActionLogger.new(current_user).log_group_deletion(group)
group.destroy!
render json: success_json
end
end
def remove_owner
group = Group.find_by(id: params.require(:id))
raise Discourse::NotFound unless group
return can_not_modify_automatic if group.automatic
guardian.ensure_can_edit_group!(group)
if params[:user_id].present?
users = [User.find_by(id: params[:user_id].to_i)]
elsif usernames = group_params[:usernames].presence
users = User.where(username: usernames.split(","))
else
raise Discourse::InvalidParameters.new(:user_id)
end
users.each do |user|
group.group_users.where(user_id: user.id).update_all(owner: false)
GroupActionLogger.new(current_user, group).log_remove_user_as_group_owner(user)
end
render json: success_json
end
def set_primary
group = Group.find_by(id: params.require(:id))
raise Discourse::NotFound unless group
users = User.where(username: group_params[:usernames].split(","))
users.each { |user| guardian.ensure_can_change_primary_group!(user, group) }
users.update_all(primary_group_id: params[:primary] == "true" ? group.id : nil)
render json: success_json
end
def automatic_membership_count
guardian.ensure_can_create_group!
domains = Group.get_valid_email_domains(params.require(:automatic_membership_email_domains))
group_id = params[:id]
user_count = 0
if domains.present?
if group_id.present?
group = Group.find_by(id: group_id)
raise Discourse::NotFound unless group
return can_not_modify_automatic if group.automatic
existing_domains = group.automatic_membership_email_domains&.split("|") || []
domains -= existing_domains
end
if domains.size > MAX_AUTO_MEMBERSHIP_DOMAINS_LOOKUP
raise Discourse::InvalidParameters.new(
I18n.t(
"groups.errors.counting_too_many_email_domains",
count: MAX_AUTO_MEMBERSHIP_DOMAINS_LOOKUP,
),
)
end
user_count = Group.automatic_membership_users(domains.join("|")).count
end
render json: { user_count: user_count }
end
protected
def can_not_modify_automatic
render_json_error(I18n.t("groups.errors.can_not_modify_automatic"))
end
private
def group_params
permitted = %i[
name
mentionable_level
messageable_level
visibility_level
members_visibility_level
automatic_membership_email_domains
title
primary_group
grant_trust_level
incoming_email
flair_icon
flair_upload_id
flair_bg_color
flair_color
bio_raw
public_admission
public_exit
allow_membership_requests
full_name
default_notification_level
membership_request_template
owner_usernames
usernames
publish_read_state
notify_users
]
custom_fields = DiscoursePluginRegistry.editable_group_custom_fields
permitted << { custom_fields: custom_fields } if custom_fields.present?
permitted << { associated_group_ids: [] } if guardian.can_associate_groups?
permitted = permitted | DiscoursePluginRegistry.group_params
params.require(:group).permit(permitted)
end
end