Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-06 13:08:40 +08:00
Code Packages Activity Actions
discourse/plugins/poll
History
Exact
Régis Hanol c51a159afb
 FIX: Display poll voters in the order they voted (#41972) 
Previously, public poll voters were displayed alphabetically by username
while pagination selected them chronologically — a regression from the
ranked choice feature (bae492efee) — so each "show more" appended an
alphabetically-sorted chunk of 25 and the overall list read as random.

This change orders voters by the same `ROW_NUMBER()` over `created_at`
that already drives pagination, restoring the pre-2024 chronological
display and aligning display order with page selection. A `user_id`
tiebreaker makes the order deterministic when votes share a timestamp
(e.g. bulk imports), and the now unused `username` column is dropped
from the query. The specs previously sorted voters by id before
asserting — which is how the regression went unnoticed — and now assert
the actual order, with vote order deliberately different from id order
so any alphabetical or id-based ordering fails.
2026-07-24 15:35:15 +02:00
..
app FEATURE: Record who closed a poll (#40989) 2026-06-29 12:22:43 +02:00
assets DEV: Add plugin APIs for extending models (#41655) 2026-07-24 13:44:01 +02:00
config I18N: Update translations (#41904) 2026-07-22 11:22:30 +02:00
db/migrate FEATURE: Record who closed a poll (#40989) 2026-06-29 12:22:43 +02:00
jobs/regular
lib FIX: Display poll voters in the order they voted (#41972) 2026-07-24 15:35:15 +02:00
spec FIX: Display poll voters in the order they voted (#41972) 2026-07-24 15:35:15 +02:00
test/javascripts DEV: Remove rich_editor site setting (#41873) 2026-07-23 19:49:20 -03:00
package.json
plugin.rb DEV: add clean_up_inactive_users_query modifier for plugins to extend query for inactive users (#41372) 2026-07-06 09:39:11 -07:00
tsconfig.json