0
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-06 13:08:40 +08:00
discourse/spec/system/nested_post_lifecycle_spec.rb
Mark VanLandingham 63c4950c90
DEV: route nested view through topic route (#40820)
## What

Draft spike for rendering nested replies through the normal topic
route/controller/template (`/t/:slug/:id[/post_number]`) instead of a
separate Ember `/n/...` browser page route.

This keeps `/n/...` for internal JSON/API endpoints and legacy browser
redirects, while using the canonical topic route for user-facing nested
topic navigation.

## Changes

- Add nested-topic loading/setup to `topic.fromParams` so `/t/...` can
render the nested tree.
- Render `<Nested>` from the topic template when the topic is in nested
mode.
- Keep the nested controller as the nested tree state owner, bridged
from the topic route/controller.
- Redirect legacy client-side `/n/...` browser routes to the
corresponding `/t/...` routes.
- Preserve nested context depth through model processing, controller
state, and cache snapshots.
- Update nested post/admin URLs, notifications, activity, copy links,
and system specs to canonical `/t/...` browser URLs.
- Split scroll-anchor persistence from full nested model cache snapshots
to avoid expensive cache writes on scroll.
- Add bounded scroll restoration retries for mobile browser-back focus
restoration.
2026-06-15 11:42:20 -05:00

268 lines
8.2 KiB
Ruby
Vendored

# frozen_string_literal: true
RSpec.describe "Nested view post lifecycle" do
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
fab!(:admin) { Fabricate(:admin, refresh_auto_groups: true) }
fab!(:topic) { Fabricate(:topic, user: user) }
fab!(:op) { Fabricate(:post, topic: topic, user: user, post_number: 1) }
let(:nested_view) { PageObjects::Pages::NestedView.new }
let(:composer) { PageObjects::Components::Composer.new }
let(:dialog) { PageObjects::Components::Dialog.new }
before do
SiteSetting.nested_replies_enabled = true
Fabricate(:nested_topic, topic: topic)
end
describe "editing a post and saving" do
fab!(:root_reply) do
Fabricate(:post, topic: topic, user: user, raw: "Original content before editing")
end
before { sign_in(user) }
it "updates the post content after saving an edit" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Original content before editing",
)
nested_view.click_post_edit_button(root_reply)
expect(composer).to be_opened
composer.fill_content("Updated content after editing")
composer.submit
expect(composer).to be_closed
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Updated content after editing",
)
expect(nested_view).to have_nested_view
end
end
describe "editing the OP and saving" do
before { sign_in(user) }
it "updates the OP content after saving an edit" do
op.update!(raw: "Original OP content that should be long enough to pass")
op.rebake!
nested_view.visit_nested(topic)
expect(page).to have_css(
".nested-view__op",
text: "Original OP content that should be long enough to pass",
)
nested_view.click_post_edit_button(op)
expect(composer).to be_opened
composer.fill_content("Updated OP content that should also be long enough")
composer.submit
expect(composer).to be_closed
expect(page).to have_css(
".nested-view__op",
text: "Updated OP content that should also be long enough",
)
end
end
describe "deleting a post" do
fab!(:root_reply) do
Fabricate(:post, topic: topic, user: user, raw: "Post that will be deleted")
end
context "when user deletes their own post" do
before { sign_in(user) }
it "shows a deleted placeholder after confirming deletion" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Post that will be deleted",
)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
end
end
context "when admin deletes a post" do
before { sign_in(admin) }
it "shows a deleted placeholder" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Post that will be deleted",
)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
end
end
end
describe "deleting a post with children" do
fab!(:root_reply) { Fabricate(:post, topic: topic, user: user, raw: "Parent with children") }
fab!(:child_reply) do
Fabricate(
:post,
topic: topic,
user: Fabricate(:user),
raw: "Child reply content",
reply_to_post_number: root_reply.post_number,
)
end
before { sign_in(admin) }
it "shows placeholder for parent but preserves children" do
nested_view.visit_nested(topic)
expect(nested_view).to have_post(root_reply)
expect(nested_view).to have_post(child_reply)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
expect(nested_view).to have_post(child_reply)
expect(page).to have_css(
"[data-post-number='#{child_reply.post_number}']",
text: "Child reply content",
)
end
end
describe "recovering a deleted post" do
fab!(:root_reply) do
Fabricate(:post, topic: topic, user: user, raw: "Post that was deleted and recovered")
end
before { sign_in(admin) }
it "clears the deleted placeholder after recovery" do
nested_view.visit_nested(topic)
expect(nested_view).to have_post(root_reply)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
nested_view.click_post_recover_button(root_reply)
expect(nested_view).to have_no_deleted_placeholder_for(root_reply)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Post that was deleted and recovered",
)
end
end
describe "staff viewing deleted post content" do
fab!(:root_reply) do
Fabricate(:post, topic: topic, user: user, raw: "Secret deleted content here")
end
context "when logged in as admin" do
before { sign_in(admin) }
it "shows an eye button to toggle deleted content visibility" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Secret deleted content here",
)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
expect(nested_view).to have_toggle_deleted_content_button_for(root_reply)
expect(nested_view).to have_no_deleted_content_visible_for(root_reply)
nested_view.click_toggle_deleted_content(root_reply)
expect(nested_view).to have_deleted_content_visible_for(root_reply)
expect(page).to have_css(
".nested-post__placeholder-reveal",
text: "Secret deleted content here",
)
end
it "hides deleted content when toggled again" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{root_reply.post_number}']",
text: "Secret deleted content here",
)
nested_view.click_post_delete_button(root_reply)
dialog.click_yes
expect(nested_view).to have_deleted_post_class_for(root_reply)
nested_view.click_toggle_deleted_content(root_reply)
expect(nested_view).to have_deleted_content_visible_for(root_reply)
nested_view.click_toggle_deleted_content(root_reply)
expect(nested_view).to have_no_deleted_content_visible_for(root_reply)
end
end
context "when logged in as regular user" do
before { sign_in(user) }
it "does not show an eye button on deleted posts" do
root_reply.update!(deleted_at: Time.current)
nested_view.visit_nested(topic)
expect(nested_view).to have_deleted_placeholder_for(root_reply)
expect(nested_view).to have_no_toggle_deleted_content_button_for(root_reply)
end
end
end
describe "editing a child post" do
fab!(:root_reply) { Fabricate(:post, topic: topic, user: Fabricate(:user), raw: "Root post") }
fab!(:child_reply) do
Fabricate(
:post,
topic: topic,
user: user,
raw: "Original child content here",
reply_to_post_number: root_reply.post_number,
)
end
before { sign_in(user) }
it "updates the child post content after saving" do
nested_view.visit_nested(topic)
expect(page).to have_css(
"[data-post-number='#{child_reply.post_number}']",
text: "Original child content here",
)
nested_view.click_post_edit_button(child_reply)
expect(composer).to be_opened
composer.fill_content("Updated child content here")
composer.submit
expect(composer).to be_closed
expect(page).to have_css(
"[data-post-number='#{child_reply.post_number}']",
text: "Updated child content here",
)
end
end
end