Discourse/discourse
Discourse/discourse
0
0
Fork 0
mirror of https://gh.wpcy.net/https://github.com/discourse/discourse.git synced 2026-05-12 01:20:18 +08:00
Code Packages Activity Actions
discourse/spec/lib/site_settings
History
Exact
Martin Brennan 679d51a985
FIX: Error in shadowed global settings for deprecated settings (#33642) 
Followup 19af83d39e

There was another edge case here, where this scenario happened:

* A site setting is deprecated _without_ an override
* This site setting is being shadowed by a global setting
* This would cause an argument error when getting the deprecated
  setting value in SiteSetting.client_settings_json_uncached

An example of this setting was `external_system_avatars_enabled`.
The shadowed setting was blowing up because it was missing the
`scoped_to` argument that was added for themeable site settings
in the referenced commit.

This commit fixes the issue and adds a spec to cover this scenario,
followup commit will add stronger handling of shadowed global
settings for theme site settings...this is not allowed.
2025-07-16 14:04:05 +10:00
..
db_provider_spec.rb DEV: Apply syntax_tree formatting to spec/* 2023-01-09 11:49:28 +00:00
defaults_provider_spec.rb DEV: Add plugin hook for transforming site setting defaults (#20941) 2023-04-05 12:28:16 +01:00
deprecated_settings_spec.rb FIX: Error in shadowed global settings for deprecated settings (#33642) 2025-07-16 14:04:05 +10:00
hidden_provider_spec.rb DEV: support un-hiding site settings programmatically (#32824) 2025-05-20 21:44:56 +02:00
local_process_provider_multisite_spec.rb DEV: Apply syntax_tree formatting to spec/* 2023-01-09 11:49:28 +00:00
local_process_provider_spec.rb DEV: Apply syntax_tree formatting to spec/* 2023-01-09 11:49:28 +00:00
type_supervisor_spec.rb FEATURE: porting type object to site settings (#32706) 2025-05-13 14:30:24 -03:00
validations_spec.rb DEV: Add setting to tag s3 objects enabling tag based access control policies (#32988) 2025-06-16 13:26:18 +08:00
yaml_loader_spec.rb DEV: Apply syntax_tree formatting to spec/* 2023-01-09 11:49:28 +00:00