mirror of
https://github.com/discourse/discourse.git
synced 2026-08-06 13:08:40 +08:00
6df9b0b357RSpec setup becomes harder to follow at either extreme: trivial fixture wrappers hide lifecycle and intent, while forcing every named operation inline repeats low-level protocol and configuration details. This change documents and applies a test-setup hierarchy: - use `fab!`, `let`, `let!`, `subject`, and inline `Fabricate` according to lifecycle and role; - use a small example-group method when parameterized behavior gives one spec useful vocabulary; - move helpers into auto-loaded `spec/support` only when they are shared across spec files; - use fabricators and page objects for the data shapes and system-test interfaces they own. Core and plugin support files are loaded centrally by `rails_helper`, so plugin-specific support loaders are unnecessary. The migration specs encountered during the sweep are removed according to repository policy; production migrations are unchanged.
23 lines
750 B
Ruby
Vendored
23 lines
750 B
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe IgnoredUser do
|
|
describe ".ignored_ids_for" do
|
|
fab!(:user)
|
|
fab!(:target, :user)
|
|
fab!(:admin) { Fabricate(:user, admin: true) }
|
|
fab!(:ignored_target) { Fabricate(:ignored_user, user: user, ignored_user: target) }
|
|
|
|
it "returns ids of users ignored by the given user" do
|
|
expect(described_class.ignored_ids_for(user)).to contain_exactly(target.id)
|
|
end
|
|
|
|
it "excludes staff even if ignored" do
|
|
Fabricate(:ignored_user, user: user, ignored_user: admin)
|
|
expect(described_class.ignored_ids_for(user)).not_to include(admin.id)
|
|
end
|
|
|
|
it "returns an empty array when user is nil" do
|
|
expect(described_class.ignored_ids_for(nil)).to eq([])
|
|
end
|
|
end
|
|
end
|
