mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 02:59:07 +08:00
c2a47a6675## Summary Previously, AI bot replies checked agent access against the author of the latest post, which meant a more privileged participant could unintentionally unlock a restricted agent for a conversation; retries could also lose the original authorization context, especially after a failed response. This change keeps topic-selected agents tied to the topic creator’s permissions, records the exact authorizing user before response generation begins, and reuses that information for retries. Explicit agent mentions still use the mentioning user’s permissions, while legacy conversations and missing users fail closed rather than guessing or inheriting access from another participant. ## Source - Patch Triage: https://patch.discourse.org/patch-triage/1180
78 lines
2.7 KiB
Ruby
Vendored
78 lines
2.7 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe PostsController do
|
|
fab!(:user) { Fabricate(:user, refresh_auto_groups: true) }
|
|
fab!(:admin) { Fabricate(:admin, refresh_auto_groups: true) }
|
|
fab!(:llm_model)
|
|
|
|
let(:bot_user) { llm_model.reload.user }
|
|
|
|
fab!(:restricted_agent) do
|
|
Fabricate(
|
|
:ai_agent,
|
|
allowed_group_ids: [Group::AUTO_GROUPS[:admins]],
|
|
allow_personal_messages: true,
|
|
)
|
|
end
|
|
|
|
before do
|
|
enable_current_plugin
|
|
toggle_enabled_bots(bots: [llm_model])
|
|
SiteSetting.ai_bot_allowed_groups = Group::AUTO_GROUPS[:trust_level_0].to_s
|
|
SiteSetting.min_personal_message_post_length = 5
|
|
end
|
|
|
|
describe "#create" do
|
|
it "uses the topic creator permissions for stored agent ids" do
|
|
topic = Fabricate(:private_message_topic, user: user, recipient: bot_user)
|
|
topic.topic_allowed_users.create!(user: admin)
|
|
topic.custom_fields["ai_agent_id"] = restricted_agent.id
|
|
topic.save_custom_fields
|
|
sign_in(admin)
|
|
|
|
expect_not_enqueued_with(job: :create_ai_reply, args: { agent_id: restricted_agent.id }) do
|
|
post "/posts.json", params: { raw: "I'll look into this.", topic_id: topic.id }
|
|
end
|
|
|
|
aggregate_failures do
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["topic_id"]).to eq(topic.id)
|
|
end
|
|
end
|
|
|
|
it "uses the topic creator permissions for legacy stored agent names" do
|
|
topic = Fabricate(:private_message_topic, user: user, recipient: bot_user)
|
|
topic.topic_allowed_users.create!(user: admin)
|
|
topic.custom_fields["ai_agent"] = restricted_agent.name
|
|
topic.save_custom_fields
|
|
sign_in(admin)
|
|
|
|
expect_not_enqueued_with(job: :create_ai_reply, args: { agent_id: restricted_agent.id }) do
|
|
post "/posts.json", params: { raw: "I'll look into this.", topic_id: topic.id }
|
|
end
|
|
|
|
aggregate_failures do
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["topic_id"]).to eq(topic.id)
|
|
end
|
|
end
|
|
|
|
it "fails closed when the topic creator no longer exists" do
|
|
topic = Fabricate(:private_message_topic, user: user, recipient: bot_user)
|
|
topic.topic_allowed_users.create!(user: admin)
|
|
topic.custom_fields["ai_agent_id"] = restricted_agent.id
|
|
topic.save_custom_fields
|
|
topic.update_columns(user_id: nil)
|
|
sign_in(admin)
|
|
|
|
expect_not_enqueued_with(job: :create_ai_reply, args: { agent_id: restricted_agent.id }) do
|
|
post "/posts.json", params: { raw: "I'll look into this.", topic_id: topic.id }
|
|
end
|
|
|
|
aggregate_failures do
|
|
expect(response.status).to eq(200)
|
|
expect(response.parsed_body["topic_id"]).to eq(topic.id)
|
|
end
|
|
end
|
|
end
|
|
end
|
