mirror of
https://github.com/discourse/discourse.git
synced 2026-08-11 01:53:26 +08:00
8f5e9a4aceThis PR removes searches by admins and moderators from the new dashboard’s Search section. This helps staff focus on what community members are searching for. Staff often search for personal or work-related topics. Including those searches adds noise and makes it harder to see what members need and what content may be missing. Key changes: * Exclude admin and moderator searches from totals, changes over time, trending searches, and content gaps. * On the Search Logs pages, rename the “Logged in only” filter to “Non-staff users” because the old filter still included admins and moderators. * Use the non-staff filter when someone clicks a trending search, so the details also leave out staff searches.
123 lines
3.8 KiB
Ruby
Vendored
123 lines
3.8 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe Admin::SearchLogsController do
|
|
fab!(:admin)
|
|
fab!(:moderator)
|
|
fab!(:user)
|
|
|
|
before { SearchLog.log(term: "ruby", search_type: :header, ip_address: "127.0.0.1") }
|
|
|
|
after { SearchLog.clear_debounce_cache! }
|
|
|
|
describe "#index" do
|
|
shared_examples "search logs accessible" do
|
|
it "returns search logs" do
|
|
get "/admin/logs/search_logs.json"
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
json = response.parsed_body
|
|
expect(json[0]["term"]).to eq("ruby")
|
|
expect(json[0]["searches"]).to eq(1)
|
|
expect(json[0]["ctr"]).to eq(0)
|
|
end
|
|
end
|
|
|
|
context "when logged in as an admin" do
|
|
before { sign_in(admin) }
|
|
|
|
include_examples "search logs accessible"
|
|
|
|
it "counts both anonymous and logged-in members' searches by default" do
|
|
Fabricate(:search_log, term: "discobot", user: user)
|
|
Fabricate.times(2, :search_log, term: "discobot")
|
|
|
|
get "/admin/logs/search_logs.json"
|
|
|
|
row = response.parsed_body.find { |entry| entry["term"] == "discobot" }
|
|
expect(row["searches"]).to eq(3)
|
|
end
|
|
|
|
it "returns only non-staff users' searches with the non_staff_only search type" do
|
|
Fabricate(:search_log, term: "member-search", user: user)
|
|
Fabricate(:search_log, term: "admin-search", user: admin)
|
|
Fabricate(:search_log, term: "moderator-search", user: moderator)
|
|
Fabricate(:search_log, term: "anonymous-search", user: nil)
|
|
|
|
get "/admin/logs/search_logs.json", params: { search_type: "non_staff_only" }
|
|
|
|
expect(response.parsed_body.map { |entry| [entry["term"], entry["searches"]] }).to eq(
|
|
[["member-search", 1]],
|
|
)
|
|
end
|
|
end
|
|
|
|
context "when logged in as a moderator" do
|
|
before { sign_in(moderator) }
|
|
|
|
include_examples "search logs accessible"
|
|
end
|
|
|
|
context "when logged in as a non-staff user" do
|
|
before { sign_in(user) }
|
|
|
|
it "denies access with a 404 response" do
|
|
get "/admin/logs/search_logs.json"
|
|
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
|
|
end
|
|
end
|
|
end
|
|
|
|
describe "#term" do
|
|
shared_examples "search log term accessible" do
|
|
it "returns search log term" do
|
|
get "/admin/logs/search_logs/term.json", params: { term: "ruby" }
|
|
|
|
expect(response.status).to eq(200)
|
|
|
|
json = response.parsed_body
|
|
expect(json["term"]["type"]).to eq("search_log_term")
|
|
expect(json["term"]["search_result"]).to be_present
|
|
end
|
|
end
|
|
|
|
context "when logged in as an admin" do
|
|
before { sign_in(admin) }
|
|
|
|
include_examples "search log term accessible"
|
|
|
|
it "returns only non-staff users' searches with the non_staff_only search type" do
|
|
Fabricate(:search_log, term: "discobot", user: user)
|
|
Fabricate(:search_log, term: "discobot", user: admin)
|
|
Fabricate(:search_log, term: "discobot", user: moderator)
|
|
Fabricate(:search_log, term: "discobot", user: nil)
|
|
|
|
get "/admin/logs/search_logs/term.json",
|
|
params: {
|
|
term: "discobot",
|
|
search_type: "non_staff_only",
|
|
}
|
|
expect(response.parsed_body["term"]["data"].sum { |point| point["y"] }).to eq(1)
|
|
end
|
|
end
|
|
|
|
context "when logged in as a moderator" do
|
|
before { sign_in(moderator) }
|
|
|
|
include_examples "search log term accessible"
|
|
end
|
|
|
|
context "when logged in as a non-staff user" do
|
|
before { sign_in(user) }
|
|
|
|
it "denies access with a 404 response" do
|
|
get "/admin/logs/search_logs/term.json", params: { term: "ruby" }
|
|
|
|
expect(response.status).to eq(404)
|
|
expect(response.parsed_body["errors"]).to include(I18n.t("not_found"))
|
|
end
|
|
end
|
|
end
|
|
end
|
