mirror of
https://gh.wpcy.net/https://github.com/discourse/discourse.git
synced 2026-05-25 06:02:57 +08:00
55b05c921b
This change seeks to improve the reliability of our system tests by resolving the lack of consistency in the state of the client side application between steps in a system test. This is achieved by patching various action methods in `Capybara::Playwright::Node` and `Capybara::Playwright::Browser` so that the methods execute an async JavaScript function on the client side that waits for the client side application to reach a settled state. A settled state is currently defined as: 1. No inflight ajax requests. (_messageBus and presence requests are excluded_) 2. 2 event cycles of the Javascript event loop has happened for for all "click", "input", "mousedown", "keydown", "focusin", "focusout", "touchstart", "change", "resize", "scroll" DOM events that fired. For debugging purposes, a `--debug-client-settled` CLI flag has been added to `bin/rspec`. When used, detailed debugging information will be printed to the browser's console as well as to `stdout` of the `bin/rspec` process. This change was inspired by https://evilmartians.com/chronicles/flaky-tests-be-gone-long-lasting-relief-chronic-ci-retry-irritation and the https://github.com/makandra/capybara-lockstep rubygem.
72 lines
2.5 KiB
Ruby
Vendored
72 lines
2.5 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
RSpec.describe "Topic voting", type: :system do
|
|
fab!(:user)
|
|
fab!(:admin) { Fabricate(:admin, trust_level: TrustLevel[4]) }
|
|
fab!(:category1, :category)
|
|
fab!(:category2, :category)
|
|
fab!(:topic1) { Fabricate(:topic, category: category1) }
|
|
fab!(:topic2) { Fabricate(:topic, category: category1) }
|
|
fab!(:topic3) { Fabricate(:topic, category: category2) }
|
|
fab!(:post1) { Fabricate(:post, topic: topic1) }
|
|
fab!(:post2) { Fabricate(:post, topic: topic2) }
|
|
|
|
let(:category_page) { PageObjects::Pages::Category.new }
|
|
let(:topic_page) { PageObjects::Pages::Topic.new }
|
|
let(:user_page) { PageObjects::Pages::User.new }
|
|
let(:admin_page) { PageObjects::Pages::AdminSiteSettings.new }
|
|
|
|
before do
|
|
SiteSetting.topic_voting_enabled = true
|
|
sign_in(admin)
|
|
end
|
|
|
|
it "enables voting in category topics and votes" do
|
|
category_page.visit(category1)
|
|
expect(category_page).to have_no_css(category_page.votes)
|
|
|
|
# enable voting in category
|
|
category_page
|
|
.visit_settings(category1)
|
|
.toggle_setting("enable-topic-voting", "Allow users to vote on topics in this category")
|
|
.save_settings
|
|
|
|
expect(Category.can_vote?(category1.id)).to eq(true)
|
|
|
|
# make a vote
|
|
category_page.visit(category1)
|
|
expect(category_page).to have_css(category_page.votes)
|
|
expect(category_page).to have_css(category_page.topic_with_vote_count(0), count: 2)
|
|
category_page.select_topic(topic1)
|
|
|
|
expect(topic_page.vote_count).to have_text("0")
|
|
topic_page.vote
|
|
expect(topic_page.vote_popup).to have_text("You have 9 votes left, see your votes")
|
|
expect(topic_page.vote_count).to have_text("1")
|
|
|
|
# visit user activity page
|
|
topic_page.click_vote_popup_activity
|
|
expect(user_page.active_user_primary_navigation).to have_text("Activity")
|
|
expect(user_page.active_user_secondary_navigation).to have_text("Votes")
|
|
expect(page).to have_css(".topic-list-body tr[data-topic-id=\"#{topic1.id}\"]", text: "1 vote")
|
|
find(".topic-list-body tr[data-topic-id=\"#{topic1.id}\"] a.raw-link").click
|
|
|
|
# unvoting
|
|
topic_page.remove_vote
|
|
expect(topic_page.vote_count).to have_text("0")
|
|
end
|
|
|
|
context "when no votes are left" do
|
|
before do
|
|
DiscourseTopicVoting::CategorySetting.create!(category: category1)
|
|
SiteSetting.topic_voting_tl4_vote_limit = 1
|
|
end
|
|
|
|
it "alerts the user" do
|
|
category_page.visit(category1).select_topic(topic1)
|
|
topic_page.vote
|
|
|
|
expect(topic_page).to have_votes_left_popup(0)
|
|
end
|
|
end
|
|
end
|
