mirror of
https://github.com/discourse/discourse.git
synced 2026-08-09 21:45:25 +08:00
fda44c33e7Reports in a dashboard section (including slow Data Explorer queries) loaded one at a time, so a single slow report delayed every other report in the section. They're now fetched in parallel on the server, so the whole section loads faster, and a report that fails to load shows its own error state without affecting the others.
87 lines
2.5 KiB
Ruby
Vendored
87 lines
2.5 KiB
Ruby
Vendored
# frozen_string_literal: true
|
|
|
|
module AdminDashboard
|
|
module Reports
|
|
class BulkFetch
|
|
FETCH_FAILED = :fetch_failed
|
|
|
|
MAX_CONCURRENT_FETCHES = 4
|
|
|
|
def self.call(items:, filters:, guardian:)
|
|
payloads = fetch_in_parallel(items, guardian:, filters:)
|
|
|
|
results =
|
|
items
|
|
.zip(payloads)
|
|
.map do |item, payload|
|
|
failed = payload == FETCH_FAILED
|
|
errored = failed || (payload.is_a?(Hash) && payload[:error].present?)
|
|
{
|
|
source: item[:source],
|
|
identifier: item[:identifier],
|
|
key: item_key(item),
|
|
data: failed ? nil : payload,
|
|
error: errored,
|
|
}
|
|
end
|
|
|
|
{ items: results }
|
|
end
|
|
|
|
def self.pool_size
|
|
available = [ActiveRecord::Base.connection_pool.size - 1, 1].max
|
|
[MAX_CONCURRENT_FETCHES, available].min
|
|
end
|
|
|
|
def self.thread_pool
|
|
@thread_pool ||=
|
|
Scheduler::ThreadPool.new(min_threads: 0, max_threads: pool_size, idle_time: 30)
|
|
end
|
|
|
|
def self.fetch_in_parallel(items, guardian:, filters:)
|
|
return [] if items.empty?
|
|
|
|
queue = Queue.new
|
|
|
|
items.each_with_index do |item, index|
|
|
thread_pool.post do
|
|
ActiveRecord::Base.with_connection(prevent_permanent_checkout: true) do
|
|
queue << [index, fetch_item(item, guardian:, filters:)]
|
|
end
|
|
rescue StandardError => e
|
|
Discourse.warn_exception(
|
|
e,
|
|
message: "Failed to fetch admin dashboard report",
|
|
env: {
|
|
source: item[:source],
|
|
identifier: item[:identifier],
|
|
},
|
|
)
|
|
queue << [index, FETCH_FAILED]
|
|
end
|
|
end
|
|
|
|
results = Array.new(items.size)
|
|
items.size.times do
|
|
index, result = queue.pop
|
|
results[index] = result
|
|
end
|
|
results
|
|
end
|
|
private_class_method :fetch_in_parallel
|
|
|
|
def self.item_key(item)
|
|
"#{item[:source]}:#{item[:identifier]}"
|
|
end
|
|
private_class_method :item_key
|
|
|
|
def self.fetch_item(item, guardian:, filters:)
|
|
provider = AdminDashboard::Reports::Registry.provider_for(item[:source])
|
|
return nil if provider.nil?
|
|
|
|
provider.fetch_many([item[:identifier]], guardian:, filters:)[item[:identifier]]
|
|
end
|
|
private_class_method :fetch_item
|
|
end
|
|
end
|
|
end
|
